The "O!" format code should implement an isinstance() test

gvanrossum · gvanrossum · commit cbfc855f57ab · 2001-08-28T16:37:51.000Z
rather than a type equality test.
diff --git a/Python/getargs.c b/Python/getargs.c
@@ -875,7 +875,7 @@ convertsimple(PyObject *arg, char **p_format, va_list *p_va, char *msgbuf)
 			type = va_arg(*p_va, PyTypeObject*);
 			p = va_arg(*p_va, PyObject **);
 			format++;
-			if (arg->ob_type == type)
+			if (PyType_IsSubtype(arg->ob_type, type))
 				*p = arg;
 			else
 				return converterr(type->tp_name, arg, msgbuf);
