gh-105922: PyImport_AddModule() uses Py_DECREF()

vstinner · vstinner · commit cef28f1c62a7 · 2023-06-22T22:38:36.000+02:00
Rewrite PyImport_AddModule() to simply call Py_DECREF(), rather than
creating a weak reference,  to get a borrowed reference to the
module.
diff --git a/Python/import.c b/Python/import.c
@@ -372,16 +372,7 @@ PyImport_AddModuleObject(PyObject *name)
     if (!mod) {
         return NULL;
     }
-
-    // gh-86160: PyImport_AddModuleObject() returns a borrowed reference
-    PyObject *ref = PyWeakref_NewRef(mod, NULL);
-    Py_DECREF(mod);
-    if (ref == NULL) {
-        return NULL;
-    }
-
-    mod = PyWeakref_GetObject(ref);
-    Py_DECREF(ref);
+    Py_DECREF(mod);  // sys.modules holds a strong reference
     return mod; /* borrowed reference */
 }
 
