mark fatal_error as noreturn (#4563)

benjaminp · web-flow · commit cef88b9c15cf · 2017-11-25T13:02:55.000-08:00
clang can't figure out that fatal_error is noreturn itself and emits warnings:

../cpython/Python/pylifecycle.c:2116:1: warning: function declared 'noreturn' should not return [-Winvalid-noreturn]
}
^
../cpython/Python/pylifecycle.c:2125:1: warning: function declared 'noreturn' should not return [-Winvalid-noreturn]
}
^
diff --git a/Python/pylifecycle.c b/Python/pylifecycle.c
@@ -2048,7 +2048,7 @@ fatal_output_debug(const char *msg)
 }
 #endif
 
-static void
+static void _Py_NO_RETURN
 fatal_error(const char *prefix, const char *msg, int status)
 {
     const int fd = fileno(stderr);

Original file line number	Diff line number	Diff line change
`@@ -2048,7 +2048,7 @@ fatal_output_debug(const char *msg)`
`2048`	`2048`	`}`
`2049`	`2049`	`#endif`
`2050`	`2050`
`2051`		`-static void`
	`2051`	`+static void _Py_NO_RETURN`
`2052`	`2052`	`fatal_error(const char prefix, const char msg, int status)`
`2053`	`2053`	`{`
`2054`	`2054`	`const int fd = fileno(stderr);`