Issue #8035: urllib: Fix a bug where the client could remain stuck after a

Charles-François Natali · Charles-François Natali · commit cf53ae2171d0 · 2011-12-18T16:05:07.000+01:00
redirection or an error.
diff --git a/Lib/urllib/request.py b/Lib/urllib/request.py
@@ -1732,7 +1732,6 @@ def http_error(self, url, fp, errcode, errmsg, headers, data=None):
 
     def http_error_default(self, url, fp, errcode, errmsg, headers):
         """Default error handler: close the connection and raise IOError."""
-        void = fp.read()
         fp.close()
         raise HTTPError(url, errcode, errmsg, headers, None)
 
@@ -1923,7 +1922,6 @@ def redirect_internal(self, url, fp, errcode, errmsg, headers, data):
             newurl = headers['uri']
         else:
             return
-        void = fp.read()
         fp.close()
 
         # In case the server sent a relative URL, join with original:
diff --git a/Misc/NEWS b/Misc/NEWS
@@ -97,6 +97,9 @@ Core and Builtins
 Library
 -------
 
+- Issue #8035: urllib: Fix a bug where the client could remain stuck after a
+  redirection or an error.
+
 - Issue #10350: Read and save errno before calling a function which might
   overwrite it.  Original patch by Hallvard B Furuseth.
 
