Add TODOs for missing Py_DECREF specializations

colesbury · colesbury · commit d0b67207c687 · 2023-10-27T10:28:28.000-04:00
These aren't necessary for correctness, just performance.
diff --git a/Include/internal/pycore_object.h b/Include/internal/pycore_object.h
@@ -210,6 +210,7 @@ _Py_DECREF_NO_DEALLOC(PyObject *op)
 }
 
 #else
+// TODO: implement Py_DECREF specializations for Py_NOGIL build
 static inline void
 _Py_DECREF_SPECIALIZED(PyObject *op, const destructor destruct)
 {
diff --git a/Python/ceval.c b/Python/ceval.c
@@ -52,6 +52,7 @@
 // the limit of PGO, and that limit cannot be configured.
 // Define them as macros to make sure that they are always inlined by the
 // preprocessor.
+// TODO: implement Py_DECREF macro for Py_NOGIL
 
 #undef Py_DECREF
 #define Py_DECREF(arg) \

Original file line number	Diff line number	Diff line change
`@@ -210,6 +210,7 @@ _Py_DECREF_NO_DEALLOC(PyObject *op)`
`210`	`210`	`}`
`211`	`211`
`212`	`212`	`#else`
	`213`	`+// TODO: implement Py_DECREF specializations for Py_NOGIL build`
`213`	`214`	`static inline void`
`214`	`215`	`_Py_DECREF_SPECIALIZED(PyObject *op, const destructor destruct)`
`215`	`216`	`{`