traverse functions should return 0 on success

jeremyhylton · jeremyhylton · commit d22162bac7e4 · 2000-06-23T17:14:56.000Z
diff --git a/Objects/classobject.c b/Objects/classobject.c
@@ -904,7 +904,7 @@ instance_traverse(PyInstanceObject *o, visitproc visit, void *arg)
 		if (err)
 			return err;
 	}
-	return 1;
+	return 0;
 }
 
 static PyObject *getitemstr, *setitemstr, *delitemstr, *lenstr;
@@ -1741,7 +1741,7 @@ instancemethod_traverse(PyMethodObject *im, visitproc visit, void *arg)
 		if (err)
 			return err;
 	}
-	return 1;
+	return 0;
 }
 
 PyTypeObject PyMethod_Type = {

Original file line number	Diff line number	Diff line change
`@@ -904,7 +904,7 @@ instance_traverse(PyInstanceObject o, visitproc visit, void arg)`
`904`	`904`	`if (err)`
`905`	`905`	`return err;`
`906`	`906`	`}`
`907`		`- return 1;`
	`907`	`+ return 0;`
`908`	`908`	`}`
`909`	`909`
`910`	`910`	`static PyObject getitemstr, setitemstr, delitemstr, lenstr;`
`@@ -1741,7 +1741,7 @@ instancemethod_traverse(PyMethodObject im, visitproc visit, void arg)`
`1741`	`1741`	`if (err)`
`1742`	`1742`	`return err;`
`1743`	`1743`	`}`
`1744`		`- return 1;`
	`1744`	`+ return 0;`
`1745`	`1745`	`}`
`1746`	`1746`
`1747`	`1747`	`PyTypeObject PyMethod_Type = {`