Issue #29513: Fixed a reference leak in os.scandir() added in issue #29034.

serhiy-storchaka · serhiy-storchaka · commit d43ab0591663 · 2017-02-09T20:02:37.000+02:00
diff --git a/Modules/posixmodule.c b/Modules/posixmodule.c
@@ -11865,7 +11865,6 @@ ScandirIterator_finalize(ScandirIterator *iterator)
         }
     }
 
-    Py_CLEAR(iterator->path.object);
     path_cleanup(&iterator->path);
 
     /* Restore the saved exception. */
@@ -11969,12 +11968,6 @@ posix_scandir(PyObject *self, PyObject *args, PyObject *kwargs)
                                      path_converter, &iterator->path))
         goto error;
 
-    /* path_converter doesn't keep path.object around, so do it
-       manually for the lifetime of the iterator here (the refcount
-       is decremented in ScandirIterator_dealloc)
-    */
-    Py_XINCREF(iterator->path.object);
-
 #ifdef MS_WINDOWS
     iterator->first_time = 1;
 
