Provide a clearer error message when urlopen fails because of an

jeremyhylton · jeremyhylton · commit d52755f41c15 · 2000-10-02T23:04:02.000Z
invalid proxy setting.

Minor change to call of unknown_url; always pass data argument
explicitly since data defaults to None.

PEP 42: Add as a feature that urllib handle proxy setting that contain
only the host and port of the proxy.
diff --git a/Lib/urllib.py b/Lib/urllib.py
@@ -142,20 +142,23 @@ def open(self, fullurl, data=None):
             fp = open(filename, 'rb')
             return addinfourl(fp, headers, fullurl)
         type, url = splittype(fullurl)
-        if not type: type = 'file'
+        if not type:
+            type = 'file'
         if self.proxies.has_key(type):
             proxy = self.proxies[type]
-            type, proxy = splittype(proxy)
-            host, selector = splithost(proxy)
+            type, proxyhost = splittype(proxy)
+            host, selector = splithost(proxyhost)
             url = (host, fullurl) # Signal special case to open_*()
+        else:
+            proxy = None
         name = 'open_' + type
         self.type = type
         if '-' in name:
             # replace - with _
             name = string.join(string.split(name, '-'), '_')
         if not hasattr(self, name):
-            if data is None:
-                return self.open_unknown(fullurl)
+            if proxy:
+                return self.open_unknown_proxy(proxy, fullurl, data)
             else:
                 return self.open_unknown(fullurl, data)
         try:
@@ -171,6 +174,11 @@ def open_unknown(self, fullurl, data=None):
         type, url = splittype(fullurl)
         raise IOError, ('url error', 'unknown url type', type)
 
+    def open_unknown_proxy(self, proxy, fullurl, data=None):
+        """Overridable interface to open unknown URL type."""
+        type, url = splittype(fullurl)
+        raise IOError, ('url error', 'invalid proxy for %s' % type, proxy)
+
     # External interface
     def retrieve(self, url, filename=None, reporthook=None, data=None):
         """retrieve(url) returns (filename, None) for a local object
