bpo-37419: Fix possible segfaults when passing large sequences to os.posix_spawn() (GH-14409)

ZackerySpytz · pablogsal · commit d52a83a3d471 · 2019-06-26T21:54:19.000+01:00
Use Py_ssize_t instead of int for i.
diff --git a/Modules/posixmodule.c b/Modules/posixmodule.c
@@ -5377,7 +5377,7 @@ parse_file_actions(PyObject *file_actions,
         return -1;
     }
 
-    for (int i = 0; i < PySequence_Fast_GET_SIZE(seq); ++i) {
+    for (Py_ssize_t i = 0; i < PySequence_Fast_GET_SIZE(seq); ++i) {
         file_action = PySequence_Fast_GET_ITEM(seq, i);
         Py_INCREF(file_action);
         if (!PyTuple_Check(file_action) || !PyTuple_GET_SIZE(file_action)) {

Original file line number	Diff line number	Diff line change
`@@ -5377,7 +5377,7 @@ parse_file_actions(PyObject *file_actions,`
`5377`	`5377`	`return -1;`
`5378`	`5378`	`}`
`5379`	`5379`
`5380`		`- for (int i = 0; i < PySequence_Fast_GET_SIZE(seq); ++i) {`
	`5380`	`+ for (Py_ssize_t i = 0; i < PySequence_Fast_GET_SIZE(seq); ++i) {`
`5381`	`5381`	`file_action = PySequence_Fast_GET_ITEM(seq, i);`
`5382`	`5382`	`Py_INCREF(file_action);`
`5383`	`5383`	`if (!PyTuple_Check(file_action) \|\| !PyTuple_GET_SIZE(file_action)) {`