The strop module and test_strop.py believe replace() with a 0 count

tim-one · tim-one · commit da45d55a6ecf · 2001-05-10T00:59:45.000Z
means "replace everything".  But the string module, string.replace()
amd test_string.py believe a 0 count means "replace nothing".
"Nothing" wins, strop loses.
Bugfix candidate.
diff --git a/Lib/test/test_strop.py b/Lib/test/test_strop.py
@@ -77,7 +77,7 @@ def __getitem__(self, i): return self.seq[i]
 test('replace', 'one!two!three!', 'one@two@three!', '!', '@', 2)
 test('replace', 'one!two!three!', 'one@two@three@', '!', '@', 3)
 test('replace', 'one!two!three!', 'one@two@three@', '!', '@', 4)
-test('replace', 'one!two!three!', 'one@two@three@', '!', '@', 0)
+test('replace', 'one!two!three!', 'one!two!three!', '!', '@', 0)
 test('replace', 'one!two!three!', 'one@two@three@', '!', '@')
 test('replace', 'one!two!three!', 'one!two!three!', 'x', '@')
 test('replace', 'one!two!three!', 'one!two!three!', 'x', '@', 2)
diff --git a/Modules/stropmodule.c b/Modules/stropmodule.c
@@ -1121,7 +1121,7 @@ strop_replace(PyObject *self, PyObject *args)
 {
 	char *str, *pat,*sub,*new_s;
 	int len,pat_len,sub_len,out_len;
-	int count = 0;
+	int count = -1;
 	PyObject *new;
 
 	if (!PyArg_ParseTuple(args, "t#t#t#|i:replace",

Original file line number	Diff line number	Diff line change
`@@ -1121,7 +1121,7 @@ strop_replace(PyObject self, PyObject args)`
`1121`	`1121`	`{`
`1122`	`1122`	`char str, pat,sub,new_s;`
`1123`	`1123`	`int len,pat_len,sub_len,out_len;`
`1124`		`- int count = 0;`
	`1124`	`+ int count = -1;`
`1125`	`1125`	`PyObject *new;`
`1126`	`1126`
`1127`	`1127`	`if (!PyArg_ParseTuple(args, "t#t#t#\|i:replace",`