Issue #24377: Fix a ref leak in OrderedDict.__repr__.

ericsnowcurrently · ericsnowcurrently · commit db4061cb9d3c · 2015-06-03T11:09:48.000-06:00
diff --git a/Misc/NEWS b/Misc/NEWS
@@ -25,6 +25,8 @@ Library
 
 - Issue #24362: Simplify the C OrderedDict fast nodes resize logic.
 
+- Issue #24377: Fix a ref leak in OrderedDict.__repr__.
+
 
 What's New in Python 3.5.0 beta 2?
 ==================================
diff --git a/Objects/odictobject.c b/Objects/odictobject.c
@@ -1578,7 +1578,7 @@ odict_repr(PyODictObject *self)
             if (value == NULL) {
                 if (!PyErr_Occurred())
                     PyErr_SetObject(PyExc_KeyError, key);
-                return NULL;
+                goto Done;
             }
             pair = PyTuple_Pack(2, key, value);
             if (pair == NULL)

Original file line number	Diff line number	Diff line change
`@@ -1578,7 +1578,7 @@ odict_repr(PyODictObject *self)`
`1578`	`1578`	`if (value == NULL) {`
`1579`	`1579`	`if (!PyErr_Occurred())`
`1580`	`1580`	`PyErr_SetObject(PyExc_KeyError, key);`
`1581`		`- return NULL;`
	`1581`	`+ goto Done;`
`1582`	`1582`	`}`
`1583`	`1583`	`pair = PyTuple_Pack(2, key, value);`
`1584`	`1584`	`if (pair == NULL)`