Issue #19420: Fix reference leak in module initalization code of _hashopenssl.c

tiran · tiran · commit db816d654640 · 2013-10-29T12:14:55.000+01:00
diff --git a/Misc/NEWS b/Misc/NEWS
@@ -28,6 +28,9 @@ Core and Builtins
 Library
 -------
 
+- Issue #19420: Fix reference leak in module initalization code of
+  _hashopenssl.c
+
 - Issue #19329: Optimized compiling charsets in regular expressions.
 
 - Issue #19227: Try to fix deadlocks caused by re-seeding then OpenSSL
diff --git a/Modules/_hashopenssl.c b/Modules/_hashopenssl.c
@@ -717,9 +717,9 @@ _openssl_hash_name_mapper(const OBJ_NAME *openssl_obj_name, void *arg)
         state->error = 1;
     } else {
         if (PySet_Add(state->set, py_name) != 0) {
-            Py_DECREF(py_name);
             state->error = 1;
         }
+        Py_DECREF(py_name);
     }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -717,9 +717,9 @@ _openssl_hash_name_mapper(const OBJ_NAME openssl_obj_name, void arg)`
`717`	`717`	`state->error = 1;`
`718`	`718`	`} else {`
`719`	`719`	`if (PySet_Add(state->set, py_name) != 0) {`
`720`		`- Py_DECREF(py_name);`
`721`	`720`	`state->error = 1;`
`722`	`721`	`}`
	`722`	`+ Py_DECREF(py_name);`
`723`	`723`	`}`
`724`	`724`	`}`
`725`	`725`