Issue #26676: Add missing XMLPullParser to ElementTree.__all__

vadmium · vadmium · commit dcfebb32e277 · 2016-04-01T06:55:55.000Z
diff --git a/Doc/whatsnew/3.6.rst b/Doc/whatsnew/3.6.rst
@@ -460,7 +460,8 @@ Changes in the Python API
 
 * The following modules have had missing APIs added to their :attr:`__all__`
   attributes to match the documented APIs: :mod:`calendar`, :mod:`csv`,
-  :mod:`enum`, :mod:`fileinput`, :mod:`ftplib`, :mod:`logging`,
+  :mod:`~xml.etree.ElementTree`, :mod:`enum`,
+  :mod:`fileinput`, :mod:`ftplib`, :mod:`logging`,
   :mod:`optparse`, :mod:`tarfile`, :mod:`threading` and
   :mod:`wave`.  This means they will export new symbols when ``import *``
   is used.  See :issue:`23883`.
diff --git a/Lib/test/test_xml_etree.py b/Lib/test/test_xml_etree.py
@@ -91,15 +91,17 @@
 
 
 class ModuleTest(unittest.TestCase):
-    # TODO: this should be removed once we get rid of the global module vars
-
     def test_sanity(self):
         # Import sanity.
 
         from xml.etree import ElementTree
         from xml.etree import ElementInclude
         from xml.etree import ElementPath
 
+    def test_all(self):
+        names = ("xml.etree.ElementTree", "_elementtree")
+        support.check__all__(self, ET, names, blacklist=("HTML_EMPTY",))
+
 
 def serialize(elem, to_string=True, encoding='unicode', **options):
     if encoding != 'unicode':
diff --git a/Lib/xml/etree/ElementTree.py b/Lib/xml/etree/ElementTree.py
@@ -85,7 +85,7 @@
     "TreeBuilder",
     "VERSION",
     "XML", "XMLID",
-    "XMLParser",
+    "XMLParser", "XMLPullParser",
     "register_namespace",
     ]
 
diff --git a/Misc/NEWS b/Misc/NEWS
@@ -237,6 +237,8 @@ Core and Builtins
 Library
 -------
 
+- Issue #26676: Added missing XMLPullParser to ElementTree.__all__.
+
 - Issue #22854: Change BufferedReader.writable() and
   BufferedWriter.readable() to always return False.
 

Original file line number	Diff line number	Diff line change
`@@ -85,7 +85,7 @@`
`85`	`85`	`"TreeBuilder",`
`86`	`86`	`"VERSION",`
`87`	`87`	`"XML", "XMLID",`
`88`		`- "XMLParser",`
	`88`	`+ "XMLParser", "XMLPullParser",`
`89`	`89`	`"register_namespace",`
`90`	`90`	`]`
`91`	`91`