Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit dd225e4

Browse files
committed
Issue #17684: Fix some test_socket failures due to limited FD passing support
on OS-X. Patch by Jeff Ramnani.
1 parent ca97fd3 commit dd225e4

1 file changed

Lines changed: 4 additions & 6 deletions

File tree

Lib/test/test_socket.py

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2533,8 +2533,7 @@ def testFDPassCMSG_LEN(self):
25332533
def _testFDPassCMSG_LEN(self):
25342534
self.createAndSendFDs(1)
25352535

2536-
# Issue #12958: The following test has problems on Mac OS X
2537-
@support.anticipate_failure(sys.platform == "darwin")
2536+
@unittest.skipIf(sys.platform == "darwin", "skipping, see issue #12958")
25382537
@requireAttrs(socket, "CMSG_SPACE")
25392538
def testFDPassSeparate(self):
25402539
# Pass two FDs in two separate arrays. Arrays may be combined
@@ -2544,7 +2543,7 @@ def testFDPassSeparate(self):
25442543
maxcmsgs=2)
25452544

25462545
@testFDPassSeparate.client_skip
2547-
@support.anticipate_failure(sys.platform == "darwin")
2546+
@unittest.skipIf(sys.platform == "darwin", "skipping, see issue #12958")
25482547
def _testFDPassSeparate(self):
25492548
fd0, fd1 = self.newFDs(2)
25502549
self.assertEqual(
@@ -2556,8 +2555,7 @@ def _testFDPassSeparate(self):
25562555
array.array("i", [fd1]))]),
25572556
len(MSG))
25582557

2559-
# Issue #12958: The following test has problems on Mac OS X
2560-
@support.anticipate_failure(sys.platform == "darwin")
2558+
@unittest.skipIf(sys.platform == "darwin", "skipping, see issue #12958")
25612559
@requireAttrs(socket, "CMSG_SPACE")
25622560
def testFDPassSeparateMinSpace(self):
25632561
# Pass two FDs in two separate arrays, receiving them into the
@@ -2569,7 +2567,7 @@ def testFDPassSeparateMinSpace(self):
25692567
maxcmsgs=2, ignoreflags=socket.MSG_CTRUNC)
25702568

25712569
@testFDPassSeparateMinSpace.client_skip
2572-
@support.anticipate_failure(sys.platform == "darwin")
2570+
@unittest.skipIf(sys.platform == "darwin", "skipping, see issue #12958")
25732571
def _testFDPassSeparateMinSpace(self):
25742572
fd0, fd1 = self.newFDs(2)
25752573
self.assertEqual(

0 commit comments

Comments
 (0)