gh-92597: Ensure that AST nodes without explicit end positions can be compiled

pablogsal · pablogsal · commit df8934db262b · 2022-05-30T18:37:24.000+01:00
diff --git a/Lib/test/test_ast.py b/Lib/test/test_ast.py
@@ -362,6 +362,25 @@ def test_invalid_position_information(self):
                 with self.assertRaises(ValueError):
                     compile(tree, '<string>', 'exec')
 
+    def test_compilation_of_ast_nodes_with_default_end_position_values(self):
+        tree = ast.Module(
+	        body=[
+                ast.Assign(
+                    targets=[
+                        ast.Name(
+                            id='a',
+                            ctx=ast.Store(),
+                            lineno=10,
+                            col_offset=10)
+                    ],
+                value=ast.Constant(
+                    value=1,
+                    lineno=10,
+                    col_offset=40),
+                lineno=10,
+                col_offset=10)],
+	        type_ignores=[])
+        compile(tree, "<string>", "exec")
 
     def test_slice(self):
         slc = ast.parse("x[::]").body[0].value.slice
diff --git a/Parser/asdl_c.py b/Parser/asdl_c.py
@@ -488,6 +488,12 @@ def visitProduct(self, prod, name):
 
 
 class Obj2ModVisitor(PickleVisitor):
+
+    attribute_special_defaults = {
+        "end_lineno": "lineno",
+        "end_col_offset": "col_offset",
+    }
+
     @contextmanager
     def recursive_call(self, node, level):
         self.emit('if (_Py_EnterRecursiveCall(" while traversing \'%s\' node")) {' % node, level, reflow=False)
@@ -637,7 +643,13 @@ def visitField(self, field, name, sum=None, prod=None, depth=0):
             self.emit("if (tmp == NULL || tmp == Py_None) {", depth)
             self.emit("Py_CLEAR(tmp);", depth+1)
             if self.isNumeric(field):
-                self.emit("%s = 0;" % field.name, depth+1)
+                if field.name in self.attribute_special_defaults:
+                    self.emit(
+                        "%s = %s;" % (field.name, self.attribute_special_defaults[field.name]),
+                        depth+1,
+                    )
+                else:
+                    self.emit("%s = 0;" % field.name, depth+1)
             elif not self.isSimpleType(field):
                 self.emit("%s = NULL;" % field.name, depth+1)
             else:
diff --git a/Python/Python-ast.c b/Python/Python-ast.c
