Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit e33aef7

Browse files
committed
__init__.py: keep it compatible with older python (True and False == 1 and 0)
test_basics.py: updated for the set_get_returns_none() default of 2 change.
1 parent 2fb7029 commit e33aef7

2 files changed

Lines changed: 17 additions & 6 deletions

File tree

Lib/bsddb/__init__.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,7 @@ def _checkCursor(self):
184184
# BerkeleyDB deadlocks (due to being opened with DB_INIT_LOCK
185185
# and DB_THREAD to be thread safe) when intermixing database
186186
# operations that use the cursor internally with those that don't.
187-
def _closeCursors(self, save=True):
187+
def _closeCursors(self, save=1):
188188
if self.dbc:
189189
c = self.dbc
190190
self.dbc = None
@@ -223,7 +223,7 @@ def __delitem__(self, key):
223223
del self.db[key]
224224

225225
def close(self):
226-
self._closeCursors(save=False)
226+
self._closeCursors(save=0)
227227
if self.dbc is not None:
228228
self.dbc.close()
229229
v = 0

Lib/bsddb/test/test_basics.py

Lines changed: 15 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -290,7 +290,7 @@ def test02_DictionaryMethods(self):
290290

291291
#----------------------------------------
292292

293-
def test03_SimpleCursorStuff(self, get_raises_error=0, set_raises_error=1):
293+
def test03_SimpleCursorStuff(self, get_raises_error=0, set_raises_error=0):
294294
if verbose:
295295
print '\n', '-=' * 30
296296
print "Running %s.test03_SimpleCursorStuff (get_error %s, set_error %s)..." % \
@@ -459,20 +459,31 @@ def test03b_SimpleCursorWithoutGetReturnsNone0(self):
459459
self.__class__.__name__
460460

461461
old = self.d.set_get_returns_none(0)
462-
assert old == 1
462+
assert old == 2
463463
self.test03_SimpleCursorStuff(get_raises_error=1, set_raises_error=1)
464464

465+
def test03b_SimpleCursorWithGetReturnsNone1(self):
466+
# same test but raise exceptions instead of returning None
467+
if verbose:
468+
print '\n', '-=' * 30
469+
print "Running %s.test03b_SimpleCursorStuffWithoutGetReturnsNone..." % \
470+
self.__class__.__name__
471+
472+
old = self.d.set_get_returns_none(1)
473+
self.test03_SimpleCursorStuff(get_raises_error=0, set_raises_error=1)
474+
475+
465476
def test03c_SimpleCursorGetReturnsNone2(self):
466477
# same test but raise exceptions instead of returning None
467478
if verbose:
468479
print '\n', '-=' * 30
469480
print "Running %s.test03c_SimpleCursorStuffWithoutSetReturnsNone..." % \
470481
self.__class__.__name__
471482

483+
old = self.d.set_get_returns_none(1)
484+
assert old == 2
472485
old = self.d.set_get_returns_none(2)
473486
assert old == 1
474-
old = self.d.set_get_returns_none(2)
475-
assert old == 2
476487
self.test03_SimpleCursorStuff(get_raises_error=0, set_raises_error=0)
477488

478489
#----------------------------------------

0 commit comments

Comments
 (0)