Fix a bug in stack overflow error handling. This fixes half of Bug

gvanrossum · gvanrossum · commit e3c3b27d33eb · 2000-10-02T10:21:59.000Z
#115555. The error from s_push() on stack overflow was -1, which was passed through unchanged by push(), but not tested for by push()'s caller -- which only expected positive error codes. Fixed by changing s_push() to return E_NOMEM on stack overflow. (Not quite the proper error code either, but I can't be bothered adding a new E_STACKOVERFLOW error code in all the right places.)
diff --git a/Parser/parser.c b/Parser/parser.c
@@ -40,7 +40,7 @@ s_push(register stack *s, dfa *d, node *parent)
 	register stackentry *top;
 	if (s->s_top == s->s_base) {
 		fprintf(stderr, "s_push: parser stack overflow\n");
-		return -1;
+		return E_NOMEM;
 	}
 	top = --s->s_top;
 	top->s_dfa = d;

Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ s_push(register stack s, dfa d, node *parent)`
`40`	`40`	`register stackentry *top;`
`41`	`41`	`if (s->s_top == s->s_base) {`
`42`	`42`	`fprintf(stderr, "s_push: parser stack overflow\n");`
`43`		`- return -1;`
	`43`	`+ return E_NOMEM;`
`44`	`44`	`}`
`45`	`45`	`top = --s->s_top;`
`46`	`46`	`top->s_dfa = d;`