Issue #4838: When a module is deallocated, free the memory backing the optional module state data.

pitrou · pitrou · commit e4bc7f69c28b · 2009-01-17T21:06:43.000Z
diff --git a/Misc/NEWS b/Misc/NEWS
@@ -12,6 +12,9 @@ What's New in Python 3.1 alpha 0
 Core and Builtins
 -----------------
 
+- Issue #4838: When a module is deallocated, free the memory backing the
+  optional module state data.
+
 - Issue #4910: Rename nb_long slot to nb_reserved, and change its
   type to (void *).
 
diff --git a/Objects/moduleobject.c b/Objects/moduleobject.c
@@ -315,6 +315,8 @@ module_dealloc(PyModuleObject *m)
 		_PyModule_Clear((PyObject *)m);
 		Py_DECREF(m->md_dict);
 	}
+	if (m->md_state != NULL)
+		PyMem_FREE(m->md_state);
 	Py_TYPE(m)->tp_free((PyObject *)m);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -315,6 +315,8 @@ module_dealloc(PyModuleObject *m)`
`315`	`315`	`_PyModule_Clear((PyObject *)m);`
`316`	`316`	`Py_DECREF(m->md_dict);`
`317`	`317`	`}`
	`318`	`+ if (m->md_state != NULL)`
	`319`	`+ PyMem_FREE(m->md_state);`
`318`	`320`	`Py_TYPE(m)->tp_free((PyObject *)m);`
`319`	`321`	`}`
`320`	`322`