Fix reversed test for failure in PySequence_List() and PySequence_Tuple().

gvanrossum · gvanrossum · commit e61093c21874 · 1997-05-14T18:43:29.000Z
This broke cPickle.
diff --git a/Objects/abstract.c b/Objects/abstract.c
@@ -806,7 +806,7 @@ PySequence_Tuple(s)
 
   for(i=0; i < l; i++)
     {
-      if(((item=PySequence_GetItem(s,i))) ||
+      if(!(item=PySequence_GetItem(s,i)) ||
 	 PyTuple_SetItem(t,i,item) == -1)
 	{
 	  Py_DECREF(t);
@@ -830,7 +830,7 @@ PySequence_List(s)
 
   for(i=0; i < l; i++)
     {
-      if((item=PySequence_GetItem(s,i)) ||
+      if(!(item=PySequence_GetItem(s,i)) ||
 	 PyList_SetItem(t,i,item) == -1)
 	{
 	  Py_DECREF(t);

Original file line number	Diff line number	Diff line change
`@@ -806,7 +806,7 @@ PySequence_Tuple(s)`
`806`	`806`
`807`	`807`	`for(i=0; i < l; i++)`
`808`	`808`	`{`
`809`		`- if(((item=PySequence_GetItem(s,i))) \|\|`
	`809`	`+ if(!(item=PySequence_GetItem(s,i)) \|\|`
`810`	`810`	`PyTuple_SetItem(t,i,item) == -1)`
`811`	`811`	`{`
`812`	`812`	`Py_DECREF(t);`
`@@ -830,7 +830,7 @@ PySequence_List(s)`
`830`	`830`
`831`	`831`	`for(i=0; i < l; i++)`
`832`	`832`	`{`
`833`		`- if((item=PySequence_GetItem(s,i)) \|\|`
	`833`	`+ if(!(item=PySequence_GetItem(s,i)) \|\|`
`834`	`834`	`PyList_SetItem(t,i,item) == -1)`
`835`	`835`	`{`
`836`	`836`	`Py_DECREF(t);`