Issue #19512: _count_elements() of _collections reuses PyId_get identifier

vstinner · vstinner · commit e7f516cbb8d4 · 2013-11-06T23:52:55.000+01:00
instead of literal "get" string
diff --git a/Modules/_collectionsmodule.c b/Modules/_collectionsmodule.c
@@ -1816,7 +1816,7 @@ _count_elements(PyObject *self, PyObject *args)
             Py_DECREF(key);
         }
     } else {
-        bound_get = PyObject_GetAttrString(mapping, "get");
+        bound_get = _PyObject_GetAttrId(mapping, &PyId_get);
         if (bound_get == NULL)
             goto done;
 

Original file line number	Diff line number	Diff line change
`@@ -1816,7 +1816,7 @@ _count_elements(PyObject self, PyObject args)`
`1816`	`1816`	`Py_DECREF(key);`
`1817`	`1817`	`}`
`1818`	`1818`	`} else {`
`1819`		`- bound_get = PyObject_GetAttrString(mapping, "get");`
	`1819`	`+ bound_get = _PyObject_GetAttrId(mapping, &PyId_get);`
`1820`	`1820`	`if (bound_get == NULL)`
`1821`	`1821`	`goto done;`
`1822`	`1822`