Fixes for issue 1752184, ensuring type objects are always created

gvanrossum · gvanrossum · commit e845c0f92244 · 2007-11-02T23:07:07.000Z
with a PyUnicode name.
diff --git a/Objects/typeobject.c b/Objects/typeobject.c
@@ -45,6 +45,7 @@ type_set_name(PyTypeObject *type, PyObject *value, void *context)
 {
 	PyHeapTypeObject* et;
 	char *tp_name;
+        PyObject *tmp;
 
 	if (!(type->tp_flags & Py_TPFLAGS_HEAPTYPE)) {
 		PyErr_Format(PyExc_TypeError,
@@ -62,14 +63,22 @@ type_set_name(PyTypeObject *type, PyObject *value, void *context)
 			     type->tp_name, Py_Type(value)->tp_name);
 		return -1;
 	}
-	tp_name = PyUnicode_AsString(value);
-	if (tp_name == NULL)
+
+        /* Check absence of null characters */
+        tmp = PyUnicode_FromStringAndSize("\0", 1);
+        if (tmp == NULL)
 		return -1;
-	if (strlen(tp_name) != (size_t)PyUnicode_GET_SIZE(value)) {
+	if (PyUnicode_Contains(value, tmp) != 0) {
+		Py_DECREF(tmp);
 		PyErr_Format(PyExc_ValueError,
 			     "__name__ must not contain null bytes");
 		return -1;
 	}
+	Py_DECREF(tmp);
+
+	tp_name = PyUnicode_AsString(value);
+	if (tp_name == NULL)
+		return -1;
 
 	et = (PyHeapTypeObject*)type;
 
diff --git a/Parser/asdl_c.py b/Parser/asdl_c.py
@@ -415,7 +415,7 @@ def visitModule(self, mod):
         }
         PyTuple_SET_ITEM(fnames, i, field);
     }
-    result = PyObject_CallFunction((PyObject*)&PyType_Type, "s(O){sOss}",
+    result = PyObject_CallFunction((PyObject*)&PyType_Type, "U(O){sOss}",
                     type, base, "_fields", fnames, "__module__", "_ast");
     Py_DECREF(fnames);
     return (PyTypeObject*)result;
diff --git a/Python/Python-ast.c b/Python/Python-ast.c
@@ -410,7 +410,7 @@ static PyTypeObject* make_type(char *type, PyTypeObject* base, char**fields, int
         }
         PyTuple_SET_ITEM(fnames, i, field);
     }
-    result = PyObject_CallFunction((PyObject*)&PyType_Type, "s(O){sOss}",
+    result = PyObject_CallFunction((PyObject*)&PyType_Type, "U(O){sOss}",
                     type, base, "_fields", fnames, "__module__", "_ast");
     Py_DECREF(fnames);
     return (PyTypeObject*)result;
diff --git a/Python/errors.c b/Python/errors.c
@@ -608,7 +608,7 @@ PyErr_NewException(const char *name, PyObject *base, PyObject *dict)
 			goto failure;
 	}
 	/* Create a real new-style class. */
-	result = PyObject_CallFunction((PyObject *)&PyType_Type, "sOO",
+	result = PyObject_CallFunction((PyObject *)&PyType_Type, "UOO",
 				       dot+1, bases, dict);
   failure:
 	Py_XDECREF(bases);

Original file line number	Diff line number	Diff line change
`@@ -415,7 +415,7 @@ def visitModule(self, mod):`
`415`	`415`	`}`
`416`	`416`	`PyTuple_SET_ITEM(fnames, i, field);`
`417`	`417`	`}`
`418`		`- result = PyObject_CallFunction((PyObject*)&PyType_Type, "s(O){sOss}",`
	`418`	`+ result = PyObject_CallFunction((PyObject*)&PyType_Type, "U(O){sOss}",`
`419`	`419`	`type, base, "_fields", fnames, "__module__", "_ast");`
`420`	`420`	`Py_DECREF(fnames);`
`421`	`421`	`return (PyTypeObject*)result;`
Original file line number	Diff line number	Diff line change
`@@ -410,7 +410,7 @@ static PyTypeObject* make_type(char type, PyTypeObject base, char**fields, int`
`410`	`410`	`}`
`411`	`411`	`PyTuple_SET_ITEM(fnames, i, field);`
`412`	`412`	`}`
`413`		`- result = PyObject_CallFunction((PyObject*)&PyType_Type, "s(O){sOss}",`
	`413`	`+ result = PyObject_CallFunction((PyObject*)&PyType_Type, "U(O){sOss}",`
`414`	`414`	`type, base, "_fields", fnames, "__module__", "_ast");`
`415`	`415`	`Py_DECREF(fnames);`
`416`	`416`	`return (PyTypeObject*)result;`
Original file line number	Diff line number	Diff line change
`@@ -608,7 +608,7 @@ PyErr_NewException(const char name, PyObject base, PyObject *dict)`
`608`	`608`	`goto failure;`
`609`	`609`	`}`
`610`	`610`	`/* Create a real new-style class. */`
`611`		`- result = PyObject_CallFunction((PyObject *)&PyType_Type, "sOO",`
	`611`	`+ result = PyObject_CallFunction((PyObject *)&PyType_Type, "UOO",`
`612`	`612`	`dot+1, bases, dict);`
`613`	`613`	`failure:`
`614`	`614`	`Py_XDECREF(bases);`