Issue #7858: Raise an error properly when os.utime() fails under Windows

pitrou · pitrou · commit e85da7aa4f57 · 2011-01-06T18:25:55.000Z
on an existing file.

(this does not seem to be easily testable)
diff --git a/Misc/NEWS b/Misc/NEWS
@@ -30,6 +30,9 @@ Core and Builtins
 Library
 -------
 
+- Issue #7858: Raise an error properly when os.utime() fails under Windows
+  on an existing file.
+
 - Issue #3839: wsgiref should not override a Content-Length header set by
   the application.  Initial patch by Clovis Fabricio.
 
diff --git a/Modules/posixmodule.c b/Modules/posixmodule.c
@@ -3256,6 +3256,7 @@ posix_utime(PyObject *self, PyObject *args)
            something is wrong with the file, when it also
            could be the time stamp that gives a problem. */
         win32_error("utime", NULL);
+        goto done;
     }
     Py_INCREF(Py_None);
     result = Py_None;

Original file line number	Diff line number	Diff line change
`@@ -3256,6 +3256,7 @@ posix_utime(PyObject self, PyObject args)`
`3256`	`3256`	`something is wrong with the file, when it also`
`3257`	`3257`	`could be the time stamp that gives a problem. */`
`3258`	`3258`	`win32_error("utime", NULL);`
	`3259`	`+ goto done;`
`3259`	`3260`	`}`
`3260`	`3261`	`Py_INCREF(Py_None);`
`3261`	`3262`	`result = Py_None;`