closes bpo-38127: _ctypes: PyObject_IsSubclass() should be checked for failure. (GH-16011)

ZackerySpytz · benjaminp · commit ea683deccc50 · 2019-09-12T11:09:32.000+01:00
An exception may occur during a PyObject_IsSubclass() call.
diff --git a/Modules/_ctypes/_ctypes.c b/Modules/_ctypes/_ctypes.c
@@ -1168,7 +1168,11 @@ PyCPointerType_from_param(PyObject *type, PyObject *value)
         */
         StgDictObject *v = PyObject_stgdict(value);
         assert(v); /* Cannot be NULL for pointer or array objects */
-        if (PyObject_IsSubclass(v->proto, typedict->proto)) {
+        int ret = PyObject_IsSubclass(v->proto, typedict->proto);
+        if (ret < 0) {
+            return NULL;
+        }
+        if (ret) {
             Py_INCREF(value);
             return value;
         }
