review suggestions

dg-pb · dg-pb · commit eb342ea78622 · 2024-06-12T20:52:31.000+03:00
diff --git a/Lib/operator.py b/Lib/operator.py
@@ -10,14 +10,13 @@
 This is the pure Python implementation of the module.
 """
 
-__all__ = ['abs', 'add', 'and_', 'attrgetter', 'call', 'concat',
-           'in_', 'not_in', 'contains', 'countOf',
+__all__ = ['abs', 'add', 'and_', 'attrgetter', 'call', 'concat', 'contains', 'countOf',
            'delitem', 'eq', 'floordiv', 'ge', 'getitem', 'gt', 'iadd', 'iand',
-           'iconcat', 'ifloordiv', 'ilshift', 'imatmul', 'imod', 'imul',
+           'iconcat', 'ifloordiv', 'ilshift', 'imatmul', 'imod', 'imul', 'in_',
            'index', 'indexOf', 'inv', 'invert', 'ior', 'ipow', 'irshift',
            'is_', 'is_not', 'isub', 'itemgetter', 'itruediv', 'ixor', 'le',
            'length_hint', 'lshift', 'lt', 'matmul', 'methodcaller', 'mod',
-           'mul', 'ne', 'neg', 'not_', 'or_', 'pos', 'pow', 'rshift',
+           'mul', 'ne', 'neg', 'not_', 'not_in', 'or_', 'pos', 'pow', 'rshift',
            'setitem', 'sub', 'truediv', 'truth', 'xor']
 
 from builtins import abs as _abs
@@ -151,22 +150,18 @@ def concat(a, b):
         raise TypeError(msg)
     return a + b
 
-
 def in_(a, b):
     "Same as a in b."
     return a in b
 
-
 def not_in(a, b):
     "Same as a not in b."
     return a not in b
 
-
 def contains(a, b):
     "Same as b in a (note reversed operands)."
     return b in a
 
-
 def countOf(a, b):
     "Return the number of items in a which are, or which equal, b."
     count = 0
diff --git a/Misc/NEWS.d/next/Library/2024-06-12-01-12-19.gh-issue-120376.R0lyvC.rst b/Misc/NEWS.d/next/Library/2024-06-12-01-12-19.gh-issue-120376.R0lyvC.rst
@@ -1 +1 @@
-:func:`operator.in_` and :func:`operator.not_in` added to ``operator`` module.
+Add :func:`operator.in_` and :func:`operator.not_in` to the :mod:`operator` module.
diff --git a/Modules/_operator.c b/Modules/_operator.c
@@ -507,7 +507,7 @@ _operator_not_in_impl(PyObject *module, PyObject *a, PyObject *b)
 {
     int result = PySequence_Contains(b, a);
     if (result != -1) {
-        result = 1 - result;
+        result = !result;
     }
     return result;
 }

Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		-:func:`operator.in_` and :func:`operator.not_in` added to ``operator`` module.
	`1`	+Add :func:`operator.in_` and :func:`operator.not_in` to the :mod:`operator` module.
Original file line number	Diff line number	Diff line change
`@@ -507,7 +507,7 @@ _operator_not_in_impl(PyObject module, PyObject a, PyObject *b)`
`507`	`507`	`{`
`508`	`508`	`int result = PySequence_Contains(b, a);`
`509`	`509`	`if (result != -1) {`
`510`		`- result = 1 - result;`
	`510`	`+ result = !result;`
`511`	`511`	`}`
`512`	`512`	`return result;`
`513`	`513`	`}`