1) Remove claim of an input invariant that is only true for static mpd_t.

Stefan Krah · Stefan Krah · commit ec766a61795a · 2012-04-10T23:11:54.000+02:00
Resizing is used _inside_ libmpdec functions, and it is permitted to
   change x-&gt;alloc several times while setting x-&gt;len at the end of the
   function. Therefore, for dynamic mpd_t x-&gt;alloc can _temporarily_ drop
   below x-&gt;len. Of course the final result always has x-&gt;len &lt;= x-&gt;alloc.

   For static mpd_t this cannot happen, since resizing to a smaller
   coefficient is a no-op.

2) Remove micro optimization in mpd_switch_to_dyn(): Previously only the
   valid initialized part of the existing coefficient up to x-&gt;len was
   copied to the new dynamic memory area. Now copying does the same as
   realloc() and the entire old memory area is copied.

   The rationale for this change is that it is no longer needed to memorize
   the explanation given in 1).
diff --git a/Modules/_decimal/libmpdec/memory.c b/Modules/_decimal/libmpdec/memory.c
@@ -222,7 +222,7 @@ mpd_switch_to_dyn(mpd_t *result, mpd_ssize_t nwords, uint32_t *status)
         return 0;
     }
 
-    memcpy(result->data, p, result->len * (sizeof *result->data));
+    memcpy(result->data, p, result->alloc * (sizeof *result->data));
     result->alloc = nwords;
     mpd_set_dynamic_data(result);
     return 1;
diff --git a/Modules/_decimal/libmpdec/mpdecimal.c b/Modules/_decimal/libmpdec/mpdecimal.c
@@ -454,9 +454,7 @@ mpd_del(mpd_t *dec)
  * Resize the coefficient. Existing data up to 'nwords' is left untouched.
  * Return 1 on success, 0 otherwise.
  *
- * Input invariants:
- *     1) MPD_MINALLOC <= result->alloc.
- *     2) 0 <= result->len <= result->alloc.
+ * Input invariant: MPD_MINALLOC <= result->alloc.
  *
  * Case nwords == result->alloc:
  *     'result' is unchanged. Return 1.

Original file line number	Diff line number	Diff line change
`@@ -222,7 +222,7 @@ mpd_switch_to_dyn(mpd_t result, mpd_ssize_t nwords, uint32_t status)`
`222`	`222`	`return 0;`
`223`	`223`	`}`
`224`	`224`
`225`		`- memcpy(result->data, p, result->len * (sizeof *result->data));`
	`225`	`+ memcpy(result->data, p, result->alloc * (sizeof *result->data));`
`226`	`226`	`result->alloc = nwords;`
`227`	`227`	`mpd_set_dynamic_data(result);`
`228`	`228`	`return 1;`
Original file line number	Diff line number	Diff line change
`@@ -454,9 +454,7 @@ mpd_del(mpd_t *dec)`
`454`	`454`	`* Resize the coefficient. Existing data up to 'nwords' is left untouched.`
`455`	`455`	`* Return 1 on success, 0 otherwise.`
`456`	`456`	`*`
`457`		`- * Input invariants:`
`458`		`- * 1) MPD_MINALLOC <= result->alloc.`
`459`		`- * 2) 0 <= result->len <= result->alloc.`
	`457`	`+ * Input invariant: MPD_MINALLOC <= result->alloc.`
`460`	`458`	`*`
`461`	`459`	`* Case nwords == result->alloc:`
`462`	`460`	`* 'result' is unchanged. Return 1.`