Issue #21311: Avoid exception in _osx_support with non-standard compiler

ned-deily · ned-deily · commit f31b4782084a · 2014-04-19T13:25:29.000-07:00
configurations.  Patch by John Szakmeister.
diff --git a/Lib/_osx_support.py b/Lib/_osx_support.py
@@ -182,7 +182,7 @@ def _find_appropriate_compiler(_config_vars):
         # Compiler is GCC, check if it is LLVM-GCC
         data = _read_output("'%s' --version"
                              % (cc.replace("'", "'\"'\"'"),))
-        if 'llvm-gcc' in data:
+        if data and 'llvm-gcc' in data:
             # Found LLVM-GCC, fall back to clang
             cc = _find_build_tool('clang')
 
diff --git a/Misc/ACKS b/Misc/ACKS
@@ -1281,6 +1281,7 @@ Andrew Svetlov
 Paul Swartz
 Thenault Sylvain
 Péter Szabó
+John Szakmeister
 Amir Szekely
 Arfrever Frehtes Taifersar Arahesis
 Hideaki Takahashi
diff --git a/Misc/NEWS b/Misc/NEWS
@@ -165,6 +165,9 @@ Library
 - asyncio: Add gi_{frame,running,code} properties to CoroWrapper
   (upstream issue #163).
 
+- Issue #21311: Avoid exception in _osx_support with non-standard compiler
+  configurations.  Patch by John Szakmeister.
+
 Extension Modules
 -----------------
 
