Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit f547863

Browse files
committed
Use Perl function prototypes to help avoid definition/usage mismatches
while modifying these files. Minor style changes to make the use of "my" with arrays more consistent.
1 parent ffb294b commit f547863

2 files changed

Lines changed: 106 additions & 102 deletions

File tree

Doc/perl/l2hinit.perl

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -99,8 +99,8 @@ sub custom_driver_hook {
9999

100100
$CUSTOM_BUTTONS = '';
101101

102-
sub make_nav_sectref {
103-
my($label,$title) = @_;
102+
sub make_nav_sectref($$) {
103+
my($label, $title) = @_;
104104
if ($title) {
105105
if ($title =~ /\<[aA] /) {
106106
$title =~ s/\<[aA] /<a class="sectref" /;
@@ -127,7 +127,7 @@ sub make_nav_sectref {
127127
$my_icon_names{'previous_page'} = 'previous';
128128
$my_icon_names{'next_page'} = 'next';
129129

130-
sub get_my_icon {
130+
sub get_my_icon($) {
131131
my $name = @_[0];
132132
my $text = $my_icon_tags{$name};
133133
if ($my_icon_names{$name}) {
@@ -141,7 +141,7 @@ sub get_my_icon {
141141
. " height=\"32\"\n alt=\"$text\" width=\"32\">";
142142
}
143143

144-
sub use_my_icon {
144+
sub use_my_icon($) {
145145
my $s = @_[0];
146146
if ($s =~ /\<tex2html_([a-z_]+)_visible_mark\>/) {
147147
my $r = get_my_icon($1);
@@ -150,7 +150,7 @@ sub use_my_icon {
150150
return $s;
151151
}
152152

153-
sub make_nav_panel {
153+
sub make_nav_panel() {
154154
my $s;
155155
my $BLANK_ICON = get_my_icon('blank');
156156
$NEXT = $NEXT_TITLE ? use_my_icon("$NEXT") : $BLANK_ICON;
@@ -192,7 +192,7 @@ sub add_child_links {
192192
return $toc;
193193
}
194194

195-
sub get_version_text {
195+
sub get_version_text() {
196196
if ($PACKAGE_VERSION ne '' && $t_date) {
197197
return ("<span class=\"release-info\">"
198198
. "Release $PACKAGE_VERSION$RELEASE_INFO,"
@@ -210,13 +210,13 @@ sub get_version_text {
210210
}
211211

212212

213-
sub top_navigation_panel {
213+
sub top_navigation_panel() {
214214
return "\n"
215215
. make_nav_panel()
216216
. "<br><hr>\n";
217217
}
218218

219-
sub bot_navigation_panel {
219+
sub bot_navigation_panel() {
220220
return "\n<p><hr>\n"
221221
. make_nav_panel()
222222
. "<hr>\n"
@@ -255,7 +255,7 @@ sub add_link {
255255
return (&inactive_img($icon), "");
256256
}
257257

258-
sub add_special_link {
258+
sub add_special_link($$$) {
259259
my($icon, $file, $current_file) = @_;
260260
if ($icon =~ /\<tex2html_([_a-z]+)_visible_mark\>/) {
261261
my $r = get_my_icon($1);
@@ -281,14 +281,14 @@ sub do_cmd_arabic {
281281
}
282282

283283

284-
sub gen_index_id {
284+
sub gen_index_id($$) {
285285
# this is used to ensure common index key generation and a stable sort
286-
my($str,$extra) = @_;
286+
my($str, $extra) = @_;
287287
sprintf('%s###%s%010d', $str, $extra, ++$global{'max_id'});
288288
}
289289

290-
sub insert_index {
291-
my($mark,$datafile,$columns,$letters,$prefix) = @_;
290+
sub insert_index($$$$$) {
291+
my($mark, $datafile, $columns, $letters, $prefix) = @_;
292292
my $prog = "$myrootdir/tools/buildindex.py";
293293
my $index;
294294
if ($letters) {
@@ -302,7 +302,7 @@ sub insert_index {
302302
}
303303
}
304304

305-
sub add_idx {
305+
sub add_idx() {
306306
print "\nBuilding HTML for the index ...";
307307
close(IDXFILE);
308308
insert_index($idx_mark, 'index.dat', $INDEX_COLUMNS, 1, '');
@@ -312,7 +312,7 @@ sub add_idx {
312312
$idx_module_mark = '<tex2html_idx_module_mark>';
313313
$idx_module_title = 'Module Index';
314314

315-
sub add_module_idx {
315+
sub add_module_idx() {
316316
print "\nBuilding HTML for the module index ...";
317317
my $key;
318318
my $first = 1;
@@ -391,7 +391,7 @@ sub do_cmd_tableofcontents {
391391
local($_) = @_;
392392
$TITLE = $toc_title;
393393
$tocfile = $CURRENT_FILE;
394-
my($closures,$reopens) = preserve_open_tags();
394+
my($closures, $reopens) = preserve_open_tags();
395395
anchor_label('contents', $CURRENT_FILE, $_); # this is added
396396
join('', "<BR>\n\\tableofchildlinks[off]", $closures
397397
, make_section_heading($toc_title, 'H2'), $toc_mark
@@ -402,7 +402,7 @@ sub do_cmd_listoffigures {
402402
local($_) = @_;
403403
$TITLE = $lof_title;
404404
$loffile = $CURRENT_FILE;
405-
my($closures,$reopens) = preserve_open_tags();
405+
my($closures, $reopens) = preserve_open_tags();
406406
anchor_label('lof', $CURRENT_FILE, $_); # this is added
407407
join('', "<BR>\n", $closures
408408
, make_section_heading($lof_title, 'H2'), $lof_mark
@@ -413,7 +413,7 @@ sub do_cmd_listoftables {
413413
local($_) = @_;
414414
$TITLE = $lot_title;
415415
$lotfile = $CURRENT_FILE;
416-
my($closures,$reopens) = preserve_open_tags();
416+
my($closures, $reopens) = preserve_open_tags();
417417
anchor_label('lot', $CURRENT_FILE, $_); # this is added
418418
join('', "<BR>\n", $closures
419419
, make_section_heading($lot_title, 'H2'), $lot_mark
@@ -455,7 +455,7 @@ sub do_cmd_textohtmlindex {
455455
if (($SHORT_INDEX) && (%index_segment)) { make_preindex(); }
456456
else { $preindex = ''; }
457457
my $heading = make_section_heading($idx_title, 'h2') . $idx_mark;
458-
my($pre,$post) = minimize_open_tags($heading);
458+
my($pre, $post) = minimize_open_tags($heading);
459459
anchor_label('genindex',$CURRENT_FILE,$_); # this is added
460460
return "<br>\n" . $pre . $_;
461461
}
@@ -585,7 +585,7 @@ sub set_depth_levels {
585585
# doctype declaration; MSIE5 on NT4 SP4 barfs on it and drops the
586586
# content of the page.
587587
$MY_PARTIAL_HEADER = '';
588-
sub make_head_and_body {
588+
sub make_head_and_body($$) {
589589
my($title, $body) = @_;
590590
$body = " $body" unless ($body eq '');
591591
my $DTDcomment = '';

0 commit comments

Comments
 (0)