merge 3.1

benjaminp · benjaminp · commit f5fcd33be9b2 · 2011-05-23T16:22:42.000-05:00
diff --git a/Lib/test/test_descr.py b/Lib/test/test_descr.py
@@ -1587,6 +1587,7 @@ def format_impl(self, spec):
             ("__floor__", math.floor, zero, set(), {}),
             ("__trunc__", math.trunc, zero, set(), {}),
             ("__ceil__", math.ceil, zero, set(), {}),
+            ("__dir__", dir, empty_seq, set(), {}),
             ]
 
         class Checker(object):
diff --git a/Misc/NEWS b/Misc/NEWS
@@ -13,6 +13,9 @@ Core and Builtins
 Library
 -------
 
+- Correct lookup of __dir__ on objects. Among other things, this causes errors
+  besides AttributeError found on lookup to be propagated.
+
 - Issue #12124: zipimport doesn't keep a reference to zlib.decompress() anymore
   to be able to unload the module.
 
diff --git a/Objects/object.c b/Objects/object.c
@@ -1366,14 +1366,15 @@ _generic_dir(PyObject *obj)
 static PyObject *
 _dir_object(PyObject *obj)
 {
-    PyObject * result = NULL;
-    PyObject * dirfunc = PyObject_GetAttrString((PyObject*)obj->ob_type,
-                                                "__dir__");
+    PyObject *result = NULL;
+    static PyObject *dir_str = NULL;
+    PyObject *dirfunc = _PyObject_LookupSpecial(obj, "__dir__", &dir_str);
 
     assert(obj);
     if (dirfunc == NULL) {
+        if (PyErr_Occurred())
+            return NULL;
         /* use default implementation */
-        PyErr_Clear();
         if (PyModule_Check(obj))
             result = _specialized_dir_module(obj);
         else if (PyType_Check(obj))
@@ -1383,7 +1384,7 @@ _dir_object(PyObject *obj)
     }
     else {
         /* use __dir__ */
-        result = PyObject_CallFunctionObjArgs(dirfunc, obj, NULL);
+        result = PyObject_CallFunctionObjArgs(dirfunc, NULL);
         Py_DECREF(dirfunc);
         if (result == NULL)
             return NULL;

Original file line number	Diff line number	Diff line change
`@@ -1587,6 +1587,7 @@ def format_impl(self, spec):`
`1587`	`1587`	`("__floor__", math.floor, zero, set(), {}),`
`1588`	`1588`	`("__trunc__", math.trunc, zero, set(), {}),`
`1589`	`1589`	`("__ceil__", math.ceil, zero, set(), {}),`
	`1590`	`+ ("__dir__", dir, empty_seq, set(), {}),`
`1590`	`1591`	`]`
`1591`	`1592`
`1592`	`1593`	`class Checker(object):`