Issue 19509: Don't call match_hostname() twice in http.client.

tiran · tiran · commit f723c711d3a7 · 2013-12-05T07:51:17.000+01:00
diff --git a/Lib/http/client.py b/Lib/http/client.py
@@ -1204,13 +1204,13 @@ def connect(self):
             server_hostname = self.host if ssl.HAS_SNI else None
             self.sock = self._context.wrap_socket(sock,
                                                   server_hostname=server_hostname)
-            try:
-                if self._check_hostname:
+            if not self._context.check_hostname and self._check_hostname:
+                try:
                     ssl.match_hostname(self.sock.getpeercert(), self.host)
-            except Exception:
-                self.sock.shutdown(socket.SHUT_RDWR)
-                self.sock.close()
-                raise
+                except Exception:
+                    self.sock.shutdown(socket.SHUT_RDWR)
+                    self.sock.close()
+                    raise
 
     __all__.append("HTTPSConnection")
 
