Issue #18394: Explicitly close the file object cgi.FieldStorage

brettcannon · brettcannon · commit f79126f373a9 · 2013-08-23T15:15:48.000-04:00
caches.

Eliminates the ResoureWarning raised during testing.

Patch also independently written by Vajrasky Kok.
diff --git a/Lib/cgi.py b/Lib/cgi.py
@@ -552,6 +552,12 @@ def __init__(self, fp=None, headers=None, outerboundary=b'',
         else:
             self.read_single()
 
+    def __del__(self):
+        try:
+            self.file.close()
+        except AttributeError:
+            pass
+
     def __repr__(self):
         """Return a printable representation."""
         return "FieldStorage(%r, %r, %r)" % (
diff --git a/Misc/NEWS b/Misc/NEWS
@@ -38,6 +38,8 @@ Core and Builtins
 Library
 -------
 
+- Issue #18394: Close cgi.FieldStorage's optional file.
+
 - Issue #17702: On error, os.environb now removes suppress the except context
   when raising a new KeyError with the original key.
 
