handle mmap_write_method

Dobatymo · Dobatymo · commit f97d2131253c · 2024-04-26T12:38:41.000+08:00
diff --git a/Misc/NEWS.d/next/Windows/2024-04-24-05-16-32.gh-issue-118209.Ryyzlz.rst b/Misc/NEWS.d/next/Windows/2024-04-24-05-16-32.gh-issue-118209.Ryyzlz.rst
@@ -1 +1 @@
-Fix crash in :func:`mmap.read` on Windows when the underlying file operation raises errors.
+Fix crashes in :func:`mmap.read`, :func:`mmap.read_byte` and :func:`mmap.write` on Windows when the underlying file operation raises errors.
diff --git a/Modules/mmapmodule.c b/Modules/mmapmodule.c
@@ -486,10 +486,15 @@ mmap_write_method(mmap_object *self,
     }
 
     CHECK_VALID_OR_RELEASE(NULL, data);
-    memcpy(&self->data[self->pos], data.buf, data.len);
-    self->pos += data.len;
-    PyBuffer_Release(&data);
-    return PyLong_FromSsize_t(data.len);
+    if (safe_memcpy(self->data + self->pos, data.buf, data.len) < 0) {
+        PyBuffer_Release(&data);
+        return NULL;
+    }
+    else {
+        self->pos += data.len;
+        PyBuffer_Release(&data);
+        return PyLong_FromSsize_t(data.len);
+    }
 }
 
 static PyObject *

Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		-Fix crash in :func:`mmap.read` on Windows when the underlying file operation raises errors.
	`1`	+Fix crashes in :func:`mmap.read`, :func:`mmap.read_byte` and :func:`mmap.write` on Windows when the underlying file operation raises errors.