Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit f980301

Browse files
committed
Finish my log of the final merge process. Mark the merge task complete.
1 parent 8dd6ffd commit f980301

1 file changed

Lines changed: 23 additions & 5 deletions

File tree

PLAN.txt

Lines changed: 23 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,7 @@ features. Run the tests. Fix bugs. Repeat until satisfied.
184184
Note: this may interact with the branch integration task.
185185

186186

187-
Project: integration with main branch
187+
Project: integration with main branch *** This is done - tim ***
188188
*************************************
189189

190190
Tasks:
@@ -217,7 +217,7 @@ Done:
217217
To undo or rename before final merge: Modules/spam.c has worked its
218218
way into the branch Unix and Windows builds (pythoncore.dsp and
219219
PC/config.c); also imported by test_descr.py. How about renaming to
220-
xxsubtype.c (whatever) now?
220+
xxsubtype.c (whatever) now? *** this is done - tim ***
221221

222222

223223
Project: performance tuning
@@ -280,17 +280,35 @@ Resolved.
280280

281281
Rebuilt from scratch; ran all tests; checked into branch about 22:40.
282282

283-
Merged descr-branch back into trunk:
283+
Merged descr-branch back into trunk (SEE BELOW -- this specific way of
284+
doing it was a bad idea):
285+
284286
cvs -q -z3 up -j descr-branch python
285287

286288
34 conflicts. Hmm! OK, looks like every file in the project with an
287289
embedded RCS Id is "a conflict". Others make no sense, e.g., a dozen
288290
conflicts in dictobject.c, sometimes enclosing identical(!) blobs of
289291
source code. And CVS remains utterly baffled by Python type object decls.
290-
Every line of ceval.c's generator code si in conflict blocks ... OK,
292+
Every line of ceval.c's generator code is in conflict blocks ... OK,
291293
there's no pattern or sense here, I'll just deal with it.
292294

293-
Conflicts resolved; rebuilt from scratch; test_weakref fails.
295+
Conflicts resolved; rebuilt from scratch; test_weakref fails. Didn't find
296+
an obvious reason and it was late, so committed it anyway. Tagged the
297+
trunk then with tag:
298+
299+
after-descr-branch-merge
300+
301+
Tracked the test_weakref failure to a botched conflict resolution in
302+
classobject.c; checked in a fix.
303+
304+
LATER: The merge should have been done via:
305+
306+
upd -j date2001-08-01 -j descr-branch python
307+
308+
instead. This would have caused only one conflict, a baffler in
309+
bltinmodule.c. It would have avoided the classobject.c error I made.
310+
Luckily, except for that one, we got to the same place in the end anyway,
311+
apart from a few curious tabs-vs-spaces differences.
294312
----------------------------------------------------------------------------
295313
2001-07-30
296314

0 commit comments

Comments
 (0)