Given that ord() of a bytes object of length 1 is defined, it should

gvanrossum · gvanrossum · commit f9e91c9c58de · 2007-05-08T21:05:48.000Z
never return a negative number.
diff --git a/Lib/test/test_builtin.py b/Lib/test/test_builtin.py
@@ -1383,6 +1383,15 @@ def test_ord(self):
         self.assertEqual(ord(' '), 32)
         self.assertEqual(ord('A'), 65)
         self.assertEqual(ord('a'), 97)
+        self.assertEqual(ord('\x80'), 128)
+        self.assertEqual(ord('\xff'), 255)
+
+        self.assertEqual(ord(b' '), 32)
+        self.assertEqual(ord(b'A'), 65)
+        self.assertEqual(ord(b'a'), 97)
+        self.assertEqual(ord(b'\x80'), 128)
+        self.assertEqual(ord(b'\xff'), 255)
+
         if have_unicode:
             self.assertEqual(ord(chr(sys.maxunicode)), sys.maxunicode)
         self.assertRaises(TypeError, ord, 42)
diff --git a/Lib/test/test_bytes.py b/Lib/test/test_bytes.py
@@ -671,6 +671,11 @@ def test_rstrip(self):
         self.assertEqual(b.rstrip(b'im'), b'mississipp')
         self.assertEqual(b.rstrip(b'pim'), b'mississ')
 
+    def test_ord(self):
+        b = b'\0A\x7f\x80\xff'
+        self.assertEqual([ord(b[i:i+1]) for i in range(len(b))],
+                         [0, 65, 127, 128, 255])
+
     # Optimizations:
     # __iter__? (optimization)
     # __reversed__? (optimization)
diff --git a/Python/bltinmodule.c b/Python/bltinmodule.c
@@ -1482,7 +1482,7 @@ builtin_ord(PyObject *self, PyObject* obj)
 		/* XXX Hopefully this is temporary */
 		size = PyBytes_GET_SIZE(obj);
 		if (size == 1) {
-			ord = (long)*PyBytes_AS_STRING(obj);
+			ord = (long)((unsigned char)*PyBytes_AS_STRING(obj));
 			return PyInt_FromLong(ord);
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -1482,7 +1482,7 @@ builtin_ord(PyObject self, PyObject obj)`
`1482`	`1482`	`/* XXX Hopefully this is temporary */`
`1483`	`1483`	`size = PyBytes_GET_SIZE(obj);`
`1484`	`1484`	`if (size == 1) {`
`1485`		`- ord = (long)*PyBytes_AS_STRING(obj);`
	`1485`	`+ ord = (long)((unsigned char)*PyBytes_AS_STRING(obj));`
`1486`	`1486`	`return PyInt_FromLong(ord);`
`1487`	`1487`	`}`
`1488`	`1488`	`}`