Issue #22185: Fix an occasional RuntimeError in threading.Condition.wait() caused by mutation of the waiters queue without holding the lock.

pitrou · pitrou · commit fa9211b11dd9 · 2014-08-29T23:27:33.000+02:00
Patch by Doug Zongker.
diff --git a/Lib/threading.py b/Lib/threading.py
@@ -290,6 +290,7 @@ def wait(self, timeout=None):
         waiter.acquire()
         self._waiters.append(waiter)
         saved_state = self._release_save()
+        gotit = False
         try:    # restore state no matter what (e.g., KeyboardInterrupt)
             if timeout is None:
                 waiter.acquire()
@@ -299,14 +300,14 @@ def wait(self, timeout=None):
                     gotit = waiter.acquire(True, timeout)
                 else:
                     gotit = waiter.acquire(False)
-                if not gotit:
-                    try:
-                        self._waiters.remove(waiter)
-                    except ValueError:
-                        pass
             return gotit
         finally:
             self._acquire_restore(saved_state)
+            if not gotit:
+                try:
+                    self._waiters.remove(waiter)
+                except ValueError:
+                    pass
 
     def wait_for(self, predicate, timeout=None):
         """Wait until a condition evaluates to True.
diff --git a/Misc/ACKS b/Misc/ACKS
@@ -1518,4 +1518,5 @@ Cheng Zhang
 Kai Zhu
 Tarek Ziadé
 Gennadiy Zlobin
+Doug Zongker
 Peter Åstrand
diff --git a/Misc/NEWS b/Misc/NEWS
@@ -124,6 +124,10 @@ Core and Builtins
 Library
 -------
 
+- Issue #22185: Fix an occasional RuntimeError in threading.Condition.wait()
+  caused by mutation of the waiters queue without holding the lock.  Patch
+  by Doug Zongker.
+
 - Issue #22287: On UNIX, _PyTime_gettimeofday() now uses
   clock_gettime(CLOCK_REALTIME) if available. As a side effect, Python now
   depends on the librt library on Solaris and on Linux (only with glibc older
