Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit fbe7b4f

Browse files
committed
Make the implementations of getElementsByTagName() and
getElementsByTagNameNS() consistent in form as well as functionality (cosmetic).
1 parent ec3dfde commit fbe7b4f

1 file changed

Lines changed: 5 additions & 11 deletions

File tree

Lib/xml/dom/minidom.py

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -551,9 +551,7 @@ def getElementsByTagName(self, name):
551551
return _getElementsByTagNameHelper(self, name, [])
552552

553553
def getElementsByTagNameNS(self, namespaceURI, localName):
554-
rc = []
555-
_getElementsByTagNameNSHelper(self, namespaceURI, localName, rc)
556-
return rc
554+
return _getElementsByTagNameNSHelper(self, namespaceURI, localName, [])
557555

558556
def __repr__(self):
559557
return "<DOM Element: %s at %s>" % (self.tagName, id(self))
@@ -881,15 +879,11 @@ def createAttributeNS(self, namespaceURI, qualifiedName):
881879
a.value = ""
882880
return a
883881

884-
def getElementsByTagNameNS(self, namespaceURI, localName):
885-
rc = []
886-
_getElementsByTagNameNSHelper(self, namespaceURI, localName, rc)
887-
return rc
888-
889882
def getElementsByTagName(self, name):
890-
rc = []
891-
_getElementsByTagNameHelper(self, name, rc)
892-
return rc
883+
return _getElementsByTagNameHelper(self, name, [])
884+
885+
def getElementsByTagNameNS(self, namespaceURI, localName):
886+
return _getElementsByTagNameNSHelper(self, namespaceURI, localName, [])
893887

894888
def writexml(self, writer, indent="", addindent="", newl=""):
895889
writer.write('<?xml version="1.0" ?>\n')

0 commit comments

Comments
 (0)