bpo-44165: pysqlite_statement_create now returns a Py object, not an int (GH-26484)

Erlend Egeberg Aasland · web-flow · commit fbf25b8c0dd1 · 2021-06-02T14:22:15.000+01:00
GH-26206 was broken by GH-26475.
diff --git a/Modules/_sqlite/statement.c b/Modules/_sqlite/statement.c
@@ -70,7 +70,7 @@ pysqlite_statement_create(pysqlite_Connection *connection, PyObject *sql)
     int max_length = sqlite3_limit(connection->db, SQLITE_LIMIT_LENGTH, -1);
     if (sql_cstr_len >= max_length) {
         PyErr_SetString(pysqlite_DataError, "query string is too large");
-        return PYSQLITE_TOO_MUCH_SQL;
+        return NULL;
     }
     if (strlen(sql_cstr) != (size_t)sql_cstr_len) {
         PyErr_SetString(PyExc_ValueError,

Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,7 @@ pysqlite_statement_create(pysqlite_Connection connection, PyObject sql)`
`70`	`70`	`int max_length = sqlite3_limit(connection->db, SQLITE_LIMIT_LENGTH, -1);`
`71`	`71`	`if (sql_cstr_len >= max_length) {`
`72`	`72`	`PyErr_SetString(pysqlite_DataError, "query string is too large");`
`73`		`- return PYSQLITE_TOO_MUCH_SQL;`
	`73`	`+ return NULL;`
`74`	`74`	`}`
`75`	`75`	`if (strlen(sql_cstr) != (size_t)sql_cstr_len) {`
`76`	`76`	`PyErr_SetString(PyExc_ValueError,`