[3.12] gh-126171: fix possible null dereference in _imp_find_frozen_impl (GH-126566) (#126568)

miss-islington · federicovalenso · web-flow · commit fc1e9e606b0f · 2024-11-08T16:26:08.000+05:30
gh-126171: fix possible null dereference in _imp_find_frozen_impl (GH-126566) (cherry picked from commit 9ecd8f7) Co-authored-by: Valery Fedorenko <federicovalenso@gmail.com>
diff --git a/Python/import.c b/Python/import.c
@@ -3539,7 +3539,7 @@ _imp_find_frozen_impl(PyObject *module, PyObject *name, int withdata)
     if (info.origname != NULL && info.origname[0] != '\0') {
         origname = PyUnicode_FromString(info.origname);
         if (origname == NULL) {
-            Py_DECREF(data);
+            Py_XDECREF(data);
             return NULL;
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -3539,7 +3539,7 @@ _imp_find_frozen_impl(PyObject module, PyObject name, int withdata)`
`3539`	`3539`	`if (info.origname != NULL && info.origname[0] != '\0') {`
`3540`	`3540`	`origname = PyUnicode_FromString(info.origname);`
`3541`	`3541`	`if (origname == NULL) {`
`3542`		`- Py_DECREF(data);`
	`3542`	`+ Py_XDECREF(data);`
`3543`	`3543`	`return NULL;`
`3544`	`3544`	`}`
`3545`	`3545`	`}`