bpo-19468: delete unnecessary instance check in importlib.reload() (GH-19424)

furkanonder · web-flow · commit fef1fae9df3b · 2020-06-05T12:56:32.000-07:00
Automerge-Triggered-By: @brettcannon
diff --git a/Lib/importlib/__init__.py b/Lib/importlib/__init__.py
@@ -54,7 +54,6 @@
 # Fully bootstrapped at this point, import whatever you like, circular
 # dependencies and startup overhead minimisation permitting :)
 
-import types
 import warnings
 
 
@@ -136,12 +135,13 @@ def reload(module):
     The module must have been successfully imported before.
 
     """
-    if not module or not isinstance(module, types.ModuleType):
-        raise TypeError("reload() argument must be a module")
     try:
         name = module.__spec__.name
     except AttributeError:
-        name = module.__name__
+        try:
+            name = module.__name__
+        except AttributeError:
+            raise TypeError("reload() argument must be a module")
 
     if sys.modules.get(name) is not module:
         msg = "module {} not in sys.modules"
diff --git a/Misc/NEWS.d/next/Core and Builtins/2020-05-30-23-18-35.bpo-19468.S-TA7p.rst b/Misc/NEWS.d/next/Core and Builtins/2020-05-30-23-18-35.bpo-19468.S-TA7p.rst
@@ -0,0 +1,2 @@
+Delete unnecessary instance check in importlib.reload().
+Patch by Furkan Önder.

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+Delete unnecessary instance check in importlib.reload().`
	`2`	`+Patch by Furkan Önder.`