Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Use PyDict_Pop() #116437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
serhiy-storchaka opened this issue Mar 6, 2024 · 0 comments
Closed

Use PyDict_Pop() #116437

serhiy-storchaka opened this issue Mar 6, 2024 · 0 comments
Labels
3.13 bugs and security fixes

Comments

@serhiy-storchaka
Copy link
Member

serhiy-storchaka commented Mar 6, 2024 •
edited by bedevere-app bot
Loading

PyDict_Pop() can be used in two cases:

  • If the PyDict_Get* call is followed by the PyDict_Del* call.
  • If the PyDict_Del* call is followed by the code that handles KeyError.

In both cases the use of PyDict_Pop() can make the code clearer.

Linked PRs
@serhiy-storchaka serhiy-storchaka added the 3.13 bugs and security fixes label Mar 6, 2024
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this issue Mar 6, 2024
@serhiy-storchaka
pythongh-116437: Use new C API PyDict_Pop() to simplify the code
b933bf8
@bedevere-app bedevere-app bot mentioned this issue Mar 6, 2024
Merged
serhiy-storchaka added a commit that referenced this issue Mar 7, 2024
@serhiy-storchaka
gh-116437: Use new C API PyDict_Pop() to simplify the code (GH-116438)
72d3cc9
adorilson pushed a commit to adorilson/cpython that referenced this issue Mar 25, 2024
@serhiy-storchaka @adorilson
pythongh-116437: Use new C API PyDict_Pop() to simplify the code (pyt…
33c372d 
…honGH-116438)
diegorusso pushed a commit to diegorusso/cpython that referenced this issue Apr 17, 2024
@serhiy-storchaka @diegorusso
pythongh-116437: Use new C API PyDict_Pop() to simplify the code (pyt…
9e1cf2f 
…honGH-116438)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.13 bugs and security fixes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@serhiy-storchaka