Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Max linker memory being set for wasi thread builds #121108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
brettcannon opened this issue Jun 27, 2024 · 6 comments
Closed

Max linker memory being set for wasi thread builds #121108

brettcannon opened this issue Jun 27, 2024 · 6 comments
Labels
build The build process and cross-build OS-wasi type-bug An unexpected behavior, bug, or error

Comments

@brettcannon
Copy link
Member

brettcannon commented Jun 27, 2024 •
edited by github-actions bot
Loading

Bug report

Bug description:

The max memory for WASI thread builds is set at:

https://github.com/python/cpython/blob/1a2e7a747540f74414e7c50556bcb2cc127e9d1c/configure.ac#L2408C59-L2408C67

But that's not enough for a build anymore:

https://github.com/brettcannon/cpython-wasi-build/actions/runs/9704017614/job/26783382753#step:7:3581

Either the limit needs to increase to at least 20971520 or be dropped entirely (probably the latter).

CPython versions tested on:

CPython main branch

Operating systems tested on:

Other
@brettcannon brettcannon added type-bug An unexpected behavior, bug, or error build The build process and cross-build OS-wasi labels Jun 27, 2024
@brettcannon
Copy link
Member Author

dicej@118e9d8 suggests the settings might not even be necessary anymore.

@brettcannon
Copy link
Member Author

Along the way the target triple should get updated to wasm32-wasip1-threads once #123877 is fixed.

@brettcannon
Copy link
Member Author

I tried deleting the configuration line, but now I get a ton of MemoryError exceptions when running the test suite.

@brettcannon
Copy link
Member Author

I might actually rip out threads support for now since it obviously isn't being used by anyone. Otherwise I will need to figure out how to fix the issues with the help of the Bytecode Alliance as I'm not sure what to do to resolve the problems and I don't know how much folks care about trying to fix the issues.

@brettcannon
Copy link
Member Author

I asked WASI folks about this, and they said to either up the memory amount to 4GB or just drop support since WASI threads is a dead-end and has not seen much uptake.

@brettcannon
Copy link
Member Author

Under wasmtime 22 and WASI SDK 24, I can't reproduce all of a sudden, so I'm going to consider this fixed.

@brettcannon brettcannon closed this as not planned Won't fix, can't repro, duplicate, stale Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build The build process and cross-build OS-wasi type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brettcannon