Codestin Search App

sharktide · 2025-03-04T17:17:39Z

Add options -nolinestop, -all, -overlap, and -strictlimits to the search function of the text class of tkinter.

Tested against

.\PCbuild\amd64\python_d.exe -m test -ugui test_tkinter

And test passed. Result:

0:00:00 [1/1] test_tkinter
0:00:27 load avg: 3.93 [1/1] test_tkinter passed

== Tests result: SUCCESS ==

1 test OK.

Total duration: 27.6 sec
Total tests: run=787 skipped=11
Total test files: run=1/1
Result: SUCCESS

Also tested against a custom test file:
[EDITED for change to new search_all method for -all and -overlap]

import tkinter as tk

root = tk.Tk()
text = tk.Text(root)
text.pack()

text.insert('1.0', 'This is a test. This is only a test.\nAnother line.\nYet another line.')

# Test without options
result = text.search('test', '1.0', 'end')
print('Without options:', result)

# Test with -nolinestop
result = text.search('line', '1.0', 'end', nolinestop=True, regexp=True)
print('With -nolinestop:', result)

# Test with search_all
result = text.search_all('test', '1.0', 'end')
print('With search_all:', result)

# Test with -overlap
result = text.search_all('test', '1.0', 'end', overlap=True)
print('With -overlap:', result)

# Test with -strictlimits
result = text.search('test', '1.0', 'end', strictlimits=True)
print('With -strictlimits:', result)

root.mainloop()

Which returns:

Without options: 1.10
With -nolinestop: 2.8
With search_all: (<textindex object: '1.10'>, <textindex object: '1.31'>)
With -overlap: (<textindex object: '1.10'>, <textindex object: '1.31'>)
With -strictlimits: 1.10

Indicating that the new features are functioning correctly

Issue: tkinter missing -nolinestop on tk.Text #130693

bedevere-app · 2025-03-04T17:17:43Z

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

sharktide · 2025-05-05T13:04:34Z

@ZeroIntensity Could someone please review? I think the original reviewer forgot

sharktide · 2025-05-10T14:40:44Z

@Wulian233 Please Review again

sharktide · 2025-05-30T16:32:59Z

I am currently pinging this PR as I have not seen a review in nearly a month.
Could someone please review?

sharktide · 2025-05-30T20:04:48Z

On it

…

On Fri, May 30, 2025 at 13:22 Peter Bierma ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In Misc/NEWS.d/next/Library/2025-03-04-17-19-26.gh-issue-130693.Kv01r8.rst <#130848 (comment)>: > @@ -0,0 +1,6 @@ +================ +Type: Enhancement We don't need this metadata. — Reply to this email directly, view it on GitHub <#130848 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BNITW52CNI3C5F6RICJESQD3BCHTXAVCNFSM6AAAAABYKCKEFWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDQOBRHE2TMNRRHE> . You are receiving this because you authored the thread.Message ID: ***@***.***>

sharktide · 2025-05-30T20:08:37Z

Done!

sharktide · 2025-06-17T13:15:52Z

It has been nearly a month. @ZeroIntensity Could you please review?

ZeroIntensity

All new features need tests. Please add one to test_tkinter.

sharktide · 2025-06-17T13:38:26Z

Will do

…

On Tue, Jun 17, 2025 at 19:07 Peter Bierma ***@***.***> wrote: ***@***.**** commented on this pull request. All new features need tests. Please add one to test_tkinter. ------------------------------ In Misc/NEWS.d/next/Library/2025-03-04-17-19-26.gh-issue-130693.Kv01r8.rst <#130848 (comment)>: > @@ -0,0 +1,2 @@ +Add support for ``-nolinestop``, ``-all``, ``-overlap``, and ``-strictlimits`` options to ``tkinter.Text.search`` ⬇️ Suggested change -Add support for ``-nolinestop``, ``-all``, ``-overlap``, and ``-strictlimits`` options to ``tkinter.Text.search`` +Add support for ``-nolinestop``, ``-all``, ``-overlap``, and ``-strictlimits`` options to :meth:`tkinter.Text.search` ------------------------------ In Lib/tkinter/__init__.py <#130848 (comment)>: > @@ -4038,9 +4038,7 @@ def scan_dragto(self, x, y): scan_mark.""" self.tk.call(self._w, 'scan', 'dragto', x, y) - def search(self, pattern, index, stopindex=None, - forwards=None, backwards=None, exact=None, - regexp=None, nocase=None, count=None, elide=None): + def search(self, pattern, index, stopindex=None, forwards=None, backwards=None, exact=None, regexp=None, nocase=None, count=None, elide=None, nolinestop=None, all=None, overlap=None, strictlimits=None): Please change it back to the old formatting. ------------------------------ In Lib/tkinter/__init__.py <#130848 (comment)>: > + + Stray newline changes: ⬇️ Suggested change - - — Reply to this email directly, view it on GitHub <#130848 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BNITW5Z32DYZL5OQEMOCKLL3EAK2TAVCNFSM6AAAAABYKCKEFWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDSMZVG4YTGOBSG4> . You are receiving this because you authored the thread.Message ID: ***@***.***>

Co-authored-by: Peter Bierma <[email protected]>

sharktide · 2025-06-17T13:48:16Z

I updated the branch as it has been a while since this PR has been opened

sharktide · 2025-09-01T18:44:27Z

Gentle ping

python-cla-bot · 2025-11-16T15:38:23Z

All commit authors signed the Contributor License Agreement.

Added tests for text.search with and without regex.

Refactor test_search_all to simplify assertions and update overlap checks.

sharktide · 2025-11-16T16:20:40Z

@serhiy-storchaka Ready for review

…30848)

bedevere-app · 2025-11-17T16:00:56Z

GH-141669 is a backport of this pull request to the 3.14 branch.

serhiy-storchaka · 2025-11-17T16:04:05Z

Thank you for your contribution, @sharktide. I rewrote the tests, so they clearly test the new options, and added many tests for already supported options. These tests will be backported.

GH-141669)

…honGH-130848) (pythonGH-141669) (cherry picked from commit 8db1aad) Co-authored-by: Serhiy Storchaka <[email protected]>

GH-141669) (GH-141670) (cherry picked from commit 8db1aad) Co-authored-by: Serhiy Storchaka <[email protected]>

…honGH-130848) * Add parameters nolinestop and strictlimits in the tkinter.Text.search() method. * Add the tkinter.Text.search_all() method. * Add more tests for tkinter.Text.search(). * stopindex is now only ignored if it is None.

Update __init__.py

8b27bcb

bedevere-app Bot added the awaiting review label Mar 4, 2025

bedevere-app Bot mentioned this pull request Mar 4, 2025

tkinter missing -nolinestop on tk.Text #130693

Closed

blurb-it Bot and others added 2 commits March 4, 2025 17:19

📜🤖 Added by blurb_it.

18d5005

Update 2025-03-04-17-19-26.gh-issue-130693.Kv01r8.rst

e2a76c2

Wulian233 reviewed Mar 5, 2025

View reviewed changes

Comment thread Misc/NEWS.d/next/Library/2025-03-04-17-19-26.gh-issue-130693.Kv01r8.rst Outdated

Update 2025-03-04-17-19-26.gh-issue-130693.Kv01r8.rst

753da3a

sharktide requested a review from Wulian233 March 5, 2025 15:20

Update 2025-03-04-17-19-26.gh-issue-130693.Kv01r8.rst

1ca30c6

Wulian233 reviewed May 5, 2025

View reviewed changes

Comment thread Misc/NEWS.d/next/Library/2025-03-04-17-19-26.gh-issue-130693.Kv01r8.rst Outdated

sharktide added 2 commits May 5, 2025 11:46

Merge branch 'python:main' into patch-130693

548e36a

pythongh-130693 Remove wordiness; only title left

6ce83e3

sharktide requested a review from Wulian233 May 5, 2025 15:49

Update 2025-03-04-17-19-26.gh-issue-130693.Kv01r8.rst

39f5875

sharktide requested a review from ZeroIntensity May 30, 2025 20:09

ZeroIntensity reviewed Jun 17, 2025

View reviewed changes

Comment thread Misc/NEWS.d/next/Library/2025-03-04-17-19-26.gh-issue-130693.Kv01r8.rst Outdated

Comment thread Lib/tkinter/__init__.py Outdated

Comment thread Lib/tkinter/__init__.py Outdated

ZeroIntensity added the topic-tkinter label Jun 17, 2025

sharktide and others added 4 commits June 17, 2025 19:13

remove whitespace in Lib/tkinter/__init__.py

ba0c98a

Co-authored-by: Peter Bierma <[email protected]>

Revert formatting in Lib/tkinter/__init__.py

754a124

Update news entry to use :meth: tags

ffd95fa

Co-authored-by: Peter Bierma <[email protected]>

Merge branch 'main' into patch-130693

72e70fc

sharktide requested a review from serhiy-storchaka August 11, 2025 20:17

Merge branch 'main' into patch-130693

9604fcb

serhiy-storchaka reviewed Sep 2, 2025

View reviewed changes

Comment thread Doc/whatsnew/3.15.rst

Comment thread Lib/test/test_tkinter/test_text.py Outdated

Comment thread Lib/test/test_tkinter/test_text.py Outdated

Comment thread Doc/whatsnew/3.15.rst Outdated

Remove unrelated change

0e50ded

sharktide added 6 commits November 16, 2025 10:40

Remove unrelated changes python#2

6ef05e3

Enhance regex tests for text widget

c0b7772

Added tests for text.search with and without regex.

Simplify test_search_all assertions in test_text.py

342a19c

Refactor test_search_all to simplify assertions and update overlap checks.

Update test assertion for search_all method

64b9930

Remove nolinestop parameter from text.search

caceee3

Merge branch 'main' into patch-130693

37577eb

sharktide requested a review from serhiy-storchaka November 16, 2025 16:20

sharktide and others added 6 commits November 16, 2025 11:33

Fix expected results in search_all test case

7e331be

Remove unnecessary comment

1f64ef2

Improve tests.

b40b474

Add more tests.

bc1685b

Make new parameters keyword-only.

d675252

Add more tests. Only ignore stopindex if it is None.

e145e60

serhiy-storchaka enabled auto-merge (squash) November 17, 2025 14:10

serhiy-storchaka merged commit 3d14805 into python:main Nov 17, 2025
46 checks passed

bedevere-app Bot removed the awaiting review label Nov 17, 2025

serhiy-storchaka pushed a commit to serhiy-storchaka/cpython that referenced this pull request Nov 17, 2025

pythongh-130693: Add more tests for tkinter.Text.search() (pythonGH-1…

93cdf3f

…30848)

serhiy-storchaka added a commit that referenced this pull request Nov 17, 2025

[3.14] gh-130693: Add more tests for tkinter.Text.search() (GH-130848) (

8db1aad

GH-141669)

serhiy-storchaka added a commit that referenced this pull request Nov 17, 2025

[3.13] gh-130693: Add more tests for tkinter.Text.search() (GH-130848) (

0280744

GH-141669) (GH-141670) (cherry picked from commit 8db1aad) Co-authored-by: Serhiy Storchaka <[email protected]>

Uh oh!

Conversation

sharktide commented Mar 4, 2025 • edited by terryjreedy Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bedevere-app Bot commented Mar 4, 2025

Uh oh!

Uh oh!

sharktide commented May 5, 2025

Uh oh!

Uh oh!

sharktide commented May 10, 2025

Uh oh!

sharktide commented May 30, 2025

Uh oh!

sharktide commented May 30, 2025 via email

Uh oh!

sharktide commented May 30, 2025

Uh oh!

sharktide commented Jun 17, 2025

Uh oh!

ZeroIntensity left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sharktide commented Jun 17, 2025 via email

Uh oh!

sharktide commented Jun 17, 2025

Uh oh!

sharktide commented Sep 1, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

python-cla-bot Bot commented Nov 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sharktide commented Nov 16, 2025

Uh oh!

Uh oh!

bedevere-app Bot commented Nov 17, 2025

Uh oh!

serhiy-storchaka commented Nov 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

sharktide commented Mar 4, 2025 •

edited by terryjreedy

Loading

python-cla-bot Bot commented Nov 16, 2025 •

edited

Loading