Bug report
PyStructSequence_New() allocates the object with PyObject_GC_NewVar() but never calls PyObject_GC_Track(). Only structseq_new_impl() (calling the type from Python) and __replace__() track the result (bpo-37126, gh-145376). All 45 C callers of PyStructSequence_New() in the tree, including make_unraisable_hook_args() in Python/errors.c, produce objects which the GC never sees, so a reference cycle through them is never collected.
Most structseq objects hold only ints and strings, but sys.UnraisableHookArgs holds the exception and its traceback, which keeps the frames alive (the current frame, when the exception has no traceback, format_unraisable_v() synthesizes one from it). Storing the hook argument in something reachable from those frames creates an uncollectable cycle:
import gc
import sys
import weakref
class Holder:
pass
def f():
holder = Holder()
def hook(unraisable):
holder.unraisable = unraisable
sys.unraisablehook = hook
class C:
def __del__(self):
raise ValueError
C()
print(gc.is_tracked(holder.unraisable))
return weakref.ref(holder)
wr = f()
sys.unraisablehook = sys.__unraisablehook__
gc.collect()
print(wr())
Output (3.13 and main):
False
<__main__.Holder object at 0x7a7fda9d22c0>
Expected: True and None.
test.support.catch_unraisable_exception() works around this by deleting its unraisable attribute on exit (bpo-37261). I hit it in test_class.test_detach_materialized_dict_no_memory(), which leaks about 140 references per run as soon as it keeps ex.unraisable in a local variable.
The simplest fix is to call _PyObject_GC_TRACK() in PyStructSequence_New(), as PyTuple_New() does, and drop the explicit calls in structseq_new_impl() and structseq_replace(). Py_VISIT() handles the NULL items of a partially filled object.
Linked PRs
Bug report
PyStructSequence_New()allocates the object withPyObject_GC_NewVar()but never callsPyObject_GC_Track(). Onlystructseq_new_impl()(calling the type from Python) and__replace__()track the result (bpo-37126, gh-145376). All 45 C callers ofPyStructSequence_New()in the tree, includingmake_unraisable_hook_args()inPython/errors.c, produce objects which the GC never sees, so a reference cycle through them is never collected.Most structseq objects hold only ints and strings, but
sys.UnraisableHookArgsholds the exception and its traceback, which keeps the frames alive (the current frame, when the exception has no traceback,format_unraisable_v()synthesizes one from it). Storing the hook argument in something reachable from those frames creates an uncollectable cycle:Output (3.13 and main):
Expected:
TrueandNone.test.support.catch_unraisable_exception()works around this by deleting itsunraisableattribute on exit (bpo-37261). I hit it intest_class.test_detach_materialized_dict_no_memory(), which leaks about 140 references per run as soon as it keepsex.unraisablein a local variable.The simplest fix is to call
_PyObject_GC_TRACK()inPyStructSequence_New(), asPyTuple_New()does, and drop the explicit calls instructseq_new_impl()andstructseq_replace().Py_VISIT()handles the NULL items of a partially filled object.Linked PRs