pkgutil.extend_path has no tests #59022

ericvsmith · 2012-05-15T19:19:00Z

BPO	14817
Nosy	@pitrou, @ericvsmith, @Windsooon
PRs	gh-59022: add tests to extend_path #12871

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2012-05-15.19:19:00.156>
labels = ['easy', 'type-feature', '3.8', '3.9', '3.7', 'tests']
title = 'pkgutil.extend_path has no tests'
updated_at = <Date 2019-07-29.18:36:31.538>
user = 'https://github.com/ericvsmith'

bugs.python.org fields:

activity = <Date 2019-07-29.18:36:31.538>
actor = 'nanjekyejoannah'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Tests']
creation = <Date 2012-05-15.19:19:00.156>
creator = 'eric.smith'
dependencies = []
files = []
hgrepos = []
issue_num = 14817
keywords = ['patch', 'easy']
message_count = 10.0
messages = ['160751', '160784', '160785', '160792', '160809', '221843', '338577', '338934', '339764', '340465']
nosy_count = 4.0
nosy_names = ['pitrou', 'eric.smith', 'Arfrever', 'Windson Yang']
pr_nums = ['12871']
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue14817'
versions = ['Python 3.7', 'Python 3.8', 'Python 3.9']

Linked PRs

The text was updated successfully, but these errors were encountered:

ericvsmith · 2012-05-15T19:19:00Z

Subject says it all.

There are also no tests of .pkg files.

python-dev · 2012-05-16T00:46:18Z

New changeset 48cb6b67d306 by Eric V. Smith in branch '3.2':
Issue bpo-14817: Add rudimentary tests for pkgutil.extend_path.
http://hg.python.org/cpython/rev/48cb6b67d306

ericvsmith · 2012-05-16T00:48:06Z

I'm going to leave this open until better tests are added. The one I did add it very simple, but it's good enough for the changes I'm about to make.

ericvsmith · 2012-05-16T01:43:22Z

This code does not clean up correctly. It needs to remove the added modules in sys.modules. I'll eventually clean it up, once bpo-14715 is addressed.

pitrou · 2012-05-16T07:54:27Z

This has broken all 3.x buildbots.

BreamoreBoy · 2014-06-29T13:34:39Z

@eric will you pick this up again?

Windsooon · 2019-03-22T02:00:16Z

I would like to work on this and make a PR.

Windsooon · 2019-03-27T01:55:31Z

My base idea would be some unittests for the function like:

class ExtendPathBaseTests(unittest.TestCase):
    def test_input_string(self):
        path = 'path'
        name = 'foo'
        self.assertEqual('path', pkgutil.extend_path(path, name))

    def test_parent_package_raise_key_error(self):
        path = ['path']
        # sys.modules['foo'] raise KeyError
        name = 'foo.bar'
        self.assertEqual(['path'], pkgutil.extend_path(path, name))

    def test_parent_package_raise_attr_error(self):
        path = ['path']
        # datetime module don't have __path__ attr
        name = 'datetime.date'
        self.assertEqual(['path'], pkgutil.extend_path(path, name))

I would move forward if we agreed.

nanjekyejoannah · 2019-04-09T15:26:31Z

@windson please open a PR for review with your code.

Windsooon · 2019-04-18T03:16:13Z

I added some tests in the PR. Actually, there are some tests for extend_path already (see https://github.com/python/cpython/blob/master/Lib/test/test_pkgutil.py#L235). However, I didn't test every line of the code in the extend_path function.

This adds tests for the documented behaviour of `pkgutil.extend_path` regarding different argument types as well as for `*.pkg` files.

…on only Co-authored-by: Petr Viktorin <[email protected]>

This adds tests for the documented behaviour of `pkgutil.extend_path` regarding different argument types as well as for `*.pkg` files.

pythonGH-121673) This adds tests for the documented behaviour of `pkgutil.extend_path` regarding different argument types as well as for `*.pkg` files. (cherry picked from commit 8f25321) Co-authored-by: Andreas Stocker <[email protected]>

…ythonGH-121673) This adds tests for the documented behaviour of `pkgutil.extend_path` regarding different argument types as well as for `*.pkg` files.

pythonGH-121673) This adds tests for the documented behaviour of `pkgutil.extend_path` regarding different argument types as well as for `*.pkg` files. (cherry picked from commit 8f25321) Co-authored-by: Andreas Stocker <[email protected]>

…H-121951) This adds tests for the documented behaviour of `pkgutil.extend_path` regarding different argument types as well as for `*.pkg` files. (cherry picked from commit 8f25321) Co-authored-by: Andreas Stocker <[email protected]>

…H-121950) This adds tests for the documented behaviour of `pkgutil.extend_path` regarding different argument types as well as for `*.pkg` files. (cherry picked from commit 8f25321) Co-authored-by: Andreas Stocker <[email protected]>

encukou · 2024-07-19T14:36:50Z

Thank you!

ericvsmith added tests Tests in the Lib/test dir easy labels May 15, 2012

Windsooon mannequin added 3.7 (EOL) end of life 3.8 (EOL) end of life 3.9 only security fixes type-feature A feature request or enhancement labels Mar 22, 2019

ezio-melotti transferred this issue from another repository Apr 10, 2022

bedevere-bot mentioned this issue Feb 5, 2023

gh-59022: add tests to extend_path #12871

Closed

bedevere-app bot mentioned this issue Jul 13, 2024

gh-59022: Added tests for pkgutil.extend_path (#59022) #121673

Merged

beachmachine added a commit to beachmachine/cpython that referenced this issue Jul 14, 2024

pythongh-59022: Removed comment from test and rely on the documentati…

814d8da

…on only Co-authored-by: Petr Viktorin <[email protected]>

encukou pushed a commit that referenced this issue Jul 16, 2024

gh-59022: Added tests for pkgutil.extend_path (#59022) (GH-121673)

8f25321

This adds tests for the documented behaviour of `pkgutil.extend_path` regarding different argument types as well as for `*.pkg` files.

bedevere-app bot mentioned this issue Jul 18, 2024

[3.12] gh-59022: Added tests for pkgutil.extend_path (GH-59022) (GH-121673) #121950

Merged

bedevere-app bot mentioned this issue Jul 18, 2024

[3.13] gh-59022: Added tests for pkgutil.extend_path (GH-59022) (GH-121673) #121951

Merged

encukou closed this as completed Jul 19, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

pkgutil.extend_path has no tests #59022

pkgutil.extend_path has no tests #59022

ericvsmith commented May 15, 2012 •

edited by bedevere-app bot

Loading

ericvsmith commented May 15, 2012

Uh oh!

python-dev mannequin commented May 16, 2012

Uh oh!

ericvsmith commented May 16, 2012

Uh oh!

ericvsmith commented May 16, 2012

Uh oh!

pitrou commented May 16, 2012

Uh oh!

BreamoreBoy mannequin commented Jun 29, 2014

Uh oh!

Windsooon mannequin commented Mar 22, 2019

Uh oh!

Windsooon mannequin commented Mar 27, 2019

Uh oh!

nanjekyejoannah commented Apr 9, 2019

Uh oh!

Windsooon mannequin commented Apr 18, 2019

Uh oh!

encukou commented Jul 19, 2024

Uh oh!

Uh oh!

pkgutil.extend_path has no tests #59022

pkgutil.extend_path has no tests #59022

Comments

ericvsmith commented May 15, 2012 • edited by bedevere-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Linked PRs

ericvsmith commented May 15, 2012

Uh oh!

python-dev mannequin commented May 16, 2012

Uh oh!

ericvsmith commented May 16, 2012

Uh oh!

ericvsmith commented May 16, 2012

Uh oh!

pitrou commented May 16, 2012

Uh oh!

BreamoreBoy mannequin commented Jun 29, 2014

Uh oh!

Windsooon mannequin commented Mar 22, 2019

Uh oh!

Windsooon mannequin commented Mar 27, 2019

Uh oh!

nanjekyejoannah commented Apr 9, 2019

Uh oh!

Windsooon mannequin commented Apr 18, 2019

Uh oh!

encukou commented Jul 19, 2024

Uh oh!

ericvsmith commented May 15, 2012 •

edited by bedevere-app bot

Loading