Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Write unit tests for pdb module #73784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
micgeronimo mannequin opened this issue Feb 19, 2017 · 6 comments
Closed

Write unit tests for pdb module #73784

micgeronimo mannequin opened this issue Feb 19, 2017 · 6 comments
Labels
3.7 (EOL) end of life tests Tests in the Lib/test dir

Comments

@micgeronimo
Copy link
Mannequin

micgeronimo mannequin commented Feb 19, 2017

BPO 29598
Nosy @methane, @xdegaye, @serhiy-storchaka, @micgeronimo, @isidentical
PRs
  • bpo-29598 Add couple of unit tests for pdb module #218
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2017-02-19.09:49:40.599>
labels = ['3.7', 'tests']
title = 'Write unit tests for pdb module'
updated_at = <Date 2019-11-30.16:37:13.325>
user = 'https://github.com/micgeronimo'

    bugs.python.org fields:

    activity = <Date 2019-11-30.16:37:13.325>
actor = 'BTaskaya'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Tests']
creation = <Date 2017-02-19.09:49:40.599>
creator = 'Artem Muterko'
dependencies = []
files = []
hgrepos = []
issue_num = 29598
keywords = []
message_count = 6.0
messages = ['288123', '288126', '288349', '288459', '288593', '357659']
nosy_count = 5.0
nosy_names = ['methane', 'xdegaye', 'serhiy.storchaka', 'Artem Muterko', 'BTaskaya']
pr_nums = ['218']
priority = 'normal'
resolution = None
stage = None
status = 'open'
superseder = None
type = None
url = 'https://bugs.python.org/issue29598'
versions = ['Python 3.7']
    @micgeronimo micgeronimo mannequin added 3.7 (EOL) end of life tests Tests in the Lib/test dir labels Feb 19, 2017
    @micgeronimo
    Copy link
    Mannequin Author

    micgeronimo mannequin commented Feb 19, 2017

    I want to write unit tests for pdb module of stdlib. Should I create one pull request for entire module or should I split work into several pull requests?

    @xdegaye
    Copy link
    Mannequin

    xdegaye mannequin commented Feb 19, 2017

    Please use one single PR only when the tests are focused on a single topic and can be collected in their own class. When the tests are focused on breakpoints for example.

    @serhiy-storchaka
    Copy link
    Member

    It would be better to move all tests for internal functions in separate TestCase class. It should be clear that this is testing of implementation details and we are free to change tests when change the implementation.

    There are some tests for find_function(). They should be moved too. Note that there is a bug in find_function() (it opens a file with default encoding).

    Tests for internal functions don't free us from testing the same functionality as a part of high level functions.

    @xdegaye
    Copy link
    Mannequin

    xdegaye mannequin commented Feb 23, 2017

    Note that there is a bug in find_function() (it opens a file with default encoding).

    Please open an issue.

    @serhiy-storchaka
    Copy link
    Member

    And decorate this test class with test.support.cpython_only.

    @isidentical
    Copy link
    Member

    PR 218 is closed and this issue looks like just created for that PR. If that PR is closed and there are nothing to do with this issue, maybe this can also be closed?

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    @iritkatriel iritkatriel closed this as not planned Won't fix, can't repro, duplicate, stale Jun 21, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life tests Tests in the Lib/test dir
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @iritkatriel @serhiy-storchaka @isidentical