From 4484f7ded370f51efb224d06a64142a36dbc04b5 Mon Sep 17 00:00:00 2001 From: "J. Nick Koston" Date: Fri, 20 Jan 2023 23:16:07 -1000 Subject: [PATCH] gh-101143: Remove references to `TimerHandle` from `asyncio.base_events.BaseEventLoop._add_callback` (GH-101197) (cherry picked from commit 9e947675ae3dc32f5863e5ed3022301cf7fd79b4) Co-authored-by: J. Nick Koston Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com> --- Lib/asyncio/base_events.py | 9 +++------ .../2023-01-20-10-46-59.gh-issue-101143.hJo8hu.rst | 2 ++ 2 files changed, 5 insertions(+), 6 deletions(-) create mode 100644 Misc/NEWS.d/next/Library/2023-01-20-10-46-59.gh-issue-101143.hJo8hu.rst diff --git a/Lib/asyncio/base_events.py b/Lib/asyncio/base_events.py index 4692f95b80eb86..c5c7bd46ff8b14 100644 --- a/Lib/asyncio/base_events.py +++ b/Lib/asyncio/base_events.py @@ -1828,12 +1828,9 @@ def call_exception_handler(self, context): exc_info=True) def _add_callback(self, handle): - """Add a Handle to _scheduled (TimerHandle) or _ready.""" - assert isinstance(handle, events.Handle), 'A Handle is required here' - if handle._cancelled: - return - assert not isinstance(handle, events.TimerHandle) - self._ready.append(handle) + """Add a Handle to _ready.""" + if not handle._cancelled: + self._ready.append(handle) def _add_callback_signalsafe(self, handle): """Like _add_callback() but called from a signal handler.""" diff --git a/Misc/NEWS.d/next/Library/2023-01-20-10-46-59.gh-issue-101143.hJo8hu.rst b/Misc/NEWS.d/next/Library/2023-01-20-10-46-59.gh-issue-101143.hJo8hu.rst new file mode 100644 index 00000000000000..d14b9e25a691fc --- /dev/null +++ b/Misc/NEWS.d/next/Library/2023-01-20-10-46-59.gh-issue-101143.hJo8hu.rst @@ -0,0 +1,2 @@ +Remove unused references to :class:`~asyncio.TimerHandle` in +``asyncio.base_events.BaseEventLoop._add_callback``.