Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-107868 Add an O(1) fastpath for sum(range(...)) #107870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

gh-107868 Add an O(1) fastpath for sum(range(...)) #107870

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
10ffc47
add fastpath for sum(range(...))
mcognetta Aug 11, 2023
bd2c5f9
fix assert
mcognetta Aug 11, 2023
2a0b4a3
fix Py_DECREF
mcognetta Aug 11, 2023
86bdcbf
📜🤖 Added by blurb_it.
blurb-it[bot] Aug 11, 2023
1bf1688
fix news and acks
mcognetta Aug 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix Py_DECREF
  • Loading branch information
@mcognetta
mcognetta committed Aug 11, 2023
commit 2a0b4a369d4af4be9acb0a6b70b96f0dfea5dfe2
24 changes: 12 additions & 12 deletions Python/bltinmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2494,7 +2494,7 @@ static PyObject* range_sum_fastpath(PyObject* module, PyObject *range)
PyObject* length = builtin_len(module, range);

if (PyObject_RichCompareBool(length, PyLong_FromLong(0), Py_EQ)) {
Py_DecRef(length);
Py_DECREF(length);
return PyLong_FromLong(0);
}

Expand Down Expand Up @@ -2523,17 +2523,17 @@ static PyObject* range_sum_fastpath(PyObject* module, PyObject *range)

PyObject* result = PyNumber_Add(d, e);

Py_DecRef(length);
Py_DecRef(start);
Py_DecRef(step);
Py_DECREF(length);
Py_DECREF(start);
Py_DECREF(step);

Py_DecRef(one);
Py_DecRef(a);
Py_DecRef(b);
Py_DecRef(two);
Py_DecRef(c);
Py_DecRef(d);
Py_DecRef(e);
Py_DECREF(one);
Py_DECREF(a);
Py_DECREF(b);
Py_DECREF(two);
Py_DECREF(c);
Py_DECREF(d);
Py_DECREF(e);

return result;
}
Expand All @@ -2551,7 +2551,7 @@ builtin_sum_impl(PyObject *module, PyObject *iterable, PyObject *start)
}
PyObject* rangesum = range_sum_fastpath(module, iterable);
result = PyNumber_Add(result, rangesum);
Py_DecRef(rangesum);
Py_DECREF(rangesum);
return result;
}

Expand Down