From bacae73ca5e2f62694c1d2f7875ffc155035e651 Mon Sep 17 00:00:00 2001 From: slow-but-steady Date: Sat, 12 Aug 2023 23:09:44 -0700 Subject: [PATCH 1/4] Remove unused `maxsize` argument from `_init` method of `queue.Queue` This is a technical debt refactor associated with the changes in commit da3caedc559d6314502ddc4b10cad8534fb9d8d1; jump to https://github.com/python/cpython/commit/da3caedc559d6314502ddc4b10cad8534fb9d8d1#diff-6434ffe17438de87d16e80921b320604b05d155909faabf9ad93e86ff68feac3L192 --- Lib/queue.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Lib/queue.py b/Lib/queue.py index 55f50088460f9e..b636c06a420617 100644 --- a/Lib/queue.py +++ b/Lib/queue.py @@ -33,7 +33,7 @@ class Queue: def __init__(self, maxsize=0): self.maxsize = maxsize - self._init(maxsize) + self._init() # mutex must be held whenever the queue is mutating. All methods # that acquire mutex must release it before returning. mutex @@ -203,7 +203,7 @@ def get_nowait(self): # These will only be called with appropriate locks held # Initialize the queue representation - def _init(self, maxsize): + def _init(self): self.queue = deque() def _qsize(self): From e5094abc692b27e9b90aa01727d7be6f87f331cb Mon Sep 17 00:00:00 2001 From: slow-but-steady Date: Sat, 12 Aug 2023 23:50:59 -0700 Subject: [PATCH 2/4] Remove unused `maxsize` argument from `queue.Queue` subclasses --- Lib/queue.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Lib/queue.py b/Lib/queue.py index b636c06a420617..a9aa01663a1cde 100644 --- a/Lib/queue.py +++ b/Lib/queue.py @@ -226,7 +226,7 @@ class PriorityQueue(Queue): Entries are typically tuples of the form: (priority number, data). ''' - def _init(self, maxsize): + def _init(self): self.queue = [] def _qsize(self): @@ -242,7 +242,7 @@ def _get(self): class LifoQueue(Queue): '''Variant of Queue that retrieves most recently added entries first.''' - def _init(self, maxsize): + def _init(self): self.queue = [] def _qsize(self): From 86368f939d780041669f341c5038dd97b8e3df25 Mon Sep 17 00:00:00 2001 From: slow-but-steady Date: Sun, 13 Aug 2023 00:47:51 -0700 Subject: [PATCH 3/4] Remove unused `maxsize` argument from all `_init` methods in `asyncio.queues` --- Lib/asyncio/queues.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Lib/asyncio/queues.py b/Lib/asyncio/queues.py index a9656a6df561ba..54a6a9632a897a 100644 --- a/Lib/asyncio/queues.py +++ b/Lib/asyncio/queues.py @@ -44,7 +44,7 @@ def __init__(self, maxsize=0): # These three are overridable in subclasses. - def _init(self, maxsize): + def _init(self): self._queue = collections.deque() def _get(self): @@ -221,7 +221,7 @@ class PriorityQueue(Queue): Entries are typically tuples of the form: (priority number, data). """ - def _init(self, maxsize): + def _init(self): self._queue = [] def _put(self, item, heappush=heapq.heappush): @@ -234,7 +234,7 @@ def _get(self, heappop=heapq.heappop): class LifoQueue(Queue): """A subclass of Queue that retrieves most recently added entries first.""" - def _init(self, maxsize): + def _init(self): self._queue = [] def _put(self, item): From 8b3df393ec241c11210bf54f5c5669c3ad1b5796 Mon Sep 17 00:00:00 2001 From: slow-but-steady Date: Sun, 13 Aug 2023 00:54:52 -0700 Subject: [PATCH 4/4] Update corresponding `_init` method call --- Lib/asyncio/queues.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Lib/asyncio/queues.py b/Lib/asyncio/queues.py index 54a6a9632a897a..825728b460478b 100644 --- a/Lib/asyncio/queues.py +++ b/Lib/asyncio/queues.py @@ -40,7 +40,7 @@ def __init__(self, maxsize=0): self._unfinished_tasks = 0 self._finished = locks.Event() self._finished.set() - self._init(maxsize) + self._init() # These three are overridable in subclasses.