From d5a2aa3d44832ae0e6c30267d43f9dfd906e39fa Mon Sep 17 00:00:00 2001 From: sobolevn Date: Wed, 6 Mar 2024 01:06:29 +0300 Subject: [PATCH 1/2] gh-116386: Fix format string "%ld" warning in `_xxinterpqueuesmodule` --- Modules/_xxinterpqueuesmodule.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Modules/_xxinterpqueuesmodule.c b/Modules/_xxinterpqueuesmodule.c index 00e49f385ee658..05a5d8502127e0 100644 --- a/Modules/_xxinterpqueuesmodule.c +++ b/Modules/_xxinterpqueuesmodule.c @@ -759,7 +759,7 @@ _queuerefs_clear(_queueref *head) #ifdef Py_DEBUG if (queue->items.count > 0) { fprintf(stderr, "queue %" PRId64 " still holds %" PRId64 " items\n", - qid, queue->items.count); + qid, (int64_t)queue->items.count); } #endif _queue_free(queue); From 895321b2e483a6199dfeb45bc47978b2fa9d0a62 Mon Sep 17 00:00:00 2001 From: sobolevn Date: Thu, 7 Mar 2024 01:20:36 +0300 Subject: [PATCH 2/2] Address review --- Modules/_xxinterpqueuesmodule.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Modules/_xxinterpqueuesmodule.c b/Modules/_xxinterpqueuesmodule.c index 05a5d8502127e0..96f6eeeea94b5e 100644 --- a/Modules/_xxinterpqueuesmodule.c +++ b/Modules/_xxinterpqueuesmodule.c @@ -758,8 +758,8 @@ _queuerefs_clear(_queueref *head) _queue_kill_and_wait(queue); #ifdef Py_DEBUG if (queue->items.count > 0) { - fprintf(stderr, "queue %" PRId64 " still holds %" PRId64 " items\n", - qid, (int64_t)queue->items.count); + fprintf(stderr, "queue %" PRId64 " still holds %zd items\n", + qid, queue->items.count); } #endif _queue_free(queue);