From 277b8a1192afa1d0e12c623f37571813649a5c5a Mon Sep 17 00:00:00 2001 From: Brandt Bucher Date: Mon, 20 May 2024 15:14:59 -0400 Subject: [PATCH 1/5] Add a "canary" tier 2 interpreter job --- .github/workflows/jit.yml | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/.github/workflows/jit.yml b/.github/workflows/jit.yml index b7938a177c856f..215fcbb7e1f8ae 100644 --- a/.github/workflows/jit.yml +++ b/.github/workflows/jit.yml @@ -26,8 +26,19 @@ concurrency: cancel-in-progress: true jobs: + interpreter: + name: Interpreter (Debug) + runs-on: ubuntu-latest + timeout-minutes: 90 + steps: + - name: If this fails, it's not the JIT's fault! + run: | + ./configure --enable-experimental-jit=interpreter --with-pydebug + make all --jobs 4 + ./python -m test --multiprocess 0 --timeout 4500 --verbose2 --verbose3 jit: name: ${{ matrix.target }} (${{ matrix.debug && 'Debug' || 'Release' }}) + needs: interpreter runs-on: ${{ matrix.runner }} timeout-minutes: 90 strategy: From 9ecadbf07b7af61d7567649a32cca44f60e8eb01 Mon Sep 17 00:00:00 2001 From: Brandt Bucher Date: Mon, 20 May 2024 15:17:08 -0400 Subject: [PATCH 2/5] It helps to have the code, I guess... --- .github/workflows/jit.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/jit.yml b/.github/workflows/jit.yml index 215fcbb7e1f8ae..3f9524bf4a7f01 100644 --- a/.github/workflows/jit.yml +++ b/.github/workflows/jit.yml @@ -31,6 +31,7 @@ jobs: runs-on: ubuntu-latest timeout-minutes: 90 steps: + - uses: actions/checkout@v4 - name: If this fails, it's not the JIT's fault! run: | ./configure --enable-experimental-jit=interpreter --with-pydebug From 735b3215bdab30cf17a6d9b95e597ad3516e6bbe Mon Sep 17 00:00:00 2001 From: Brandt Bucher Date: Thu, 23 May 2024 09:48:52 -0400 Subject: [PATCH 3/5] Require the interpreter job everywhere --- .github/workflows/jit.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/jit.yml b/.github/workflows/jit.yml index 3f9524bf4a7f01..6006f98ad1a760 100644 --- a/.github/workflows/jit.yml +++ b/.github/workflows/jit.yml @@ -165,6 +165,7 @@ jobs: jit-with-disabled-gil: name: Free-Threaded (Debug) + needs: interpreter runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 From a4ef2d15b389e2205db976e34a46d8703b9a7f17 Mon Sep 17 00:00:00 2001 From: Brandt Bucher Date: Thu, 23 May 2024 22:49:22 -0400 Subject: [PATCH 4/5] Split up the build and test steps --- .github/workflows/jit.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/jit.yml b/.github/workflows/jit.yml index 6006f98ad1a760..b46713343dd0bc 100644 --- a/.github/workflows/jit.yml +++ b/.github/workflows/jit.yml @@ -32,10 +32,12 @@ jobs: timeout-minutes: 90 steps: - uses: actions/checkout@v4 - - name: If this fails, it's not the JIT's fault! + - name: Build Tier Two Interpreter run: | ./configure --enable-experimental-jit=interpreter --with-pydebug make all --jobs 4 + - name: Test Tier Two Interpreter + run: | ./python -m test --multiprocess 0 --timeout 4500 --verbose2 --verbose3 jit: name: ${{ matrix.target }} (${{ matrix.debug && 'Debug' || 'Release' }}) From 2218132ce45fc0b82f55589a2e39a23ecc8506cc Mon Sep 17 00:00:00 2001 From: Brandt Bucher Date: Thu, 23 May 2024 22:50:43 -0400 Subject: [PATCH 5/5] lowercase --- .github/workflows/jit.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/jit.yml b/.github/workflows/jit.yml index b46713343dd0bc..8c760a81d52662 100644 --- a/.github/workflows/jit.yml +++ b/.github/workflows/jit.yml @@ -32,11 +32,11 @@ jobs: timeout-minutes: 90 steps: - uses: actions/checkout@v4 - - name: Build Tier Two Interpreter + - name: Build tier two interpreter run: | ./configure --enable-experimental-jit=interpreter --with-pydebug make all --jobs 4 - - name: Test Tier Two Interpreter + - name: Test tier two interpreter run: | ./python -m test --multiprocess 0 --timeout 4500 --verbose2 --verbose3 jit: