From 67442d259899bdba1972da1d5cc125cfd9e392da Mon Sep 17 00:00:00 2001 From: Diego Russo Date: Wed, 5 Mar 2025 14:58:49 +0000 Subject: [PATCH 1/2] gh-129964: Fix JIT crash on Windows on Arm Updating to clang-19 change the code generation of the JIT stencils. This caused some addresses of symbols to be far away hence it was impossible to reach them out. Enabling the -fplt restores the behaviour that we had with clang-18. --- Tools/jit/_targets.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Tools/jit/_targets.py b/Tools/jit/_targets.py index 7eb433e2a5b207..8d1e809d30cc38 100644 --- a/Tools/jit/_targets.py +++ b/Tools/jit/_targets.py @@ -499,7 +499,7 @@ def get_target(host: str) -> _COFF | _ELF | _MachO: if re.fullmatch(r"aarch64-apple-darwin.*", host): target = _MachO(host, alignment=8, prefix="_") elif re.fullmatch(r"aarch64-pc-windows-msvc", host): - args = ["-fms-runtime-lib=dll"] + args = ["-fms-runtime-lib=dll", "-fplt"] target = _COFF(host, alignment=8, args=args) elif re.fullmatch(r"aarch64-.*-linux-gnu", host): args = [ From 3a7add0f3a063ed3f54ee7d3d2e95fc00a16c533 Mon Sep 17 00:00:00 2001 From: "blurb-it[bot]" <43283697+blurb-it[bot]@users.noreply.github.com> Date: Wed, 5 Mar 2025 15:19:23 +0000 Subject: [PATCH 2/2] =?UTF-8?q?=F0=9F=93=9C=F0=9F=A4=96=20Added=20by=20blu?= =?UTF-8?q?rb=5Fit.?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../2025-03-05-15-19-21.gh-issue-129964.jqu89w.rst | 1 + 1 file changed, 1 insertion(+) create mode 100644 Misc/NEWS.d/next/Core_and_Builtins/2025-03-05-15-19-21.gh-issue-129964.jqu89w.rst diff --git a/Misc/NEWS.d/next/Core_and_Builtins/2025-03-05-15-19-21.gh-issue-129964.jqu89w.rst b/Misc/NEWS.d/next/Core_and_Builtins/2025-03-05-15-19-21.gh-issue-129964.jqu89w.rst new file mode 100644 index 00000000000000..7f2c6b280c648b --- /dev/null +++ b/Misc/NEWS.d/next/Core_and_Builtins/2025-03-05-15-19-21.gh-issue-129964.jqu89w.rst @@ -0,0 +1 @@ +Fix JIT crash on Windows on Arm. Patch by Diego Russo and Brandt Bucher.